Files
fixin.me/test/system/units_test.rb
cryptogopher 5d051de666 Check for out of range float values
Remove unsupported attribute `[maxlength]` from `input[number]`.
2026-07-20 21:45:33 +02:00

279 lines
9.4 KiB
Ruby

require "application_system_test_case"
# Fixture prerequisites:
# * user with multiple units:
# * at least 1 w/o subunit,
# * at least 1 w/ single subunit,
# * at least 1 w/ multiple subunits:
# * at least 1 subunit w/ multiplier == 1.0,
# * at least 1 subunit w/ multiplier != 10^[-]N,
# * user with single unit,
# * user with no units.
# Users need to be active and confirmed. Units w/ and w/o description.
class UnitsTest < ApplicationSystemTestCase
def sign_in(...)
@link_labels = nil
@user = super { click_on t('units.navigation') }
end
def link_labels
@link_labels ||= {
new_unit: t('units.index.new_unit'),
new_subunit: t('units.unit.new_subunit'),
edit: Regexp.union(@user.units.map(&:symbol))
}
end
def list_symbols
all(:table_cell, column(:symbol))
.select{ |cell| cell.has_sibling?(:table_cell, wait: 0) }
.map(&:text)
end
test "index" do
sign_in
if @user.units.empty?
assert_selector :table, rows: [[t('units.no_items')]]
else
column = column(:symbol)
assert_selector :table, rows_with: @user.units.map { |u| {column => u.symbol} }
end
end
test "new and create" do
sign_in
symbols = list_symbols
actions = @user.units.empty? ? [:new_unit] : [:new_unit, :new_subunit]
link_labels.slice!(*actions)
action, label = link_labels.to_a.sample
all(:link, exact_text: label).sample.then do |link|
link.click
assert_matches_selector link, :link, disabled: true
end
attributes = [:symbol, :description]
attributes << :multiplier if action == :new_subunit
within :table_row, {}, with_focus: true do
attributes.map! do |name|
field = find(:table_cell, column(name)).find(:fillable_field)
value = case name
when :symbol
random_string(1..3, 4..field[:maxlength].to_i,
allow_blank: false, except: symbols)
when :description
random_string(0, 1..field[:maxlength].to_i)
when :multiplier
if rand < 0.5
random_float(min: field[:min].to_f, max: field[:max].to_f)
else
10.0**rand(-15..15)
end
end
field.fill_in with: value
[name, value]
end
click_on t('helpers.submit.create')
end
attributes = attributes.to_h
assert_selector '.flash.notice', exact_text: t('units.create.success',
unit: attributes[:symbol])
new_symbols = list_symbols
within :table do
assert_no_selector :fillable_field
assert_equal symbols.length + 1, new_symbols.length
multiplier = attributes.delete(:multiplier).to_f if action == :new_subunit
within :table_row, attributes.transform_keys { |k| column(k) } do
assert_selector :table_cell, column(:multiplier), with: multiplier if multiplier
end
end
assert_no_selector :link, disabled: true,
exact_text: Regexp.union(link_labels.values)
refresh
assert_equal new_symbols, list_symbols
end
test "create fails with out of range multiplier" do
sign_in(user: users.select { |u| u.confirmed? && !u.units.empty? }.sample)
all(:link, exact_text: link_labels[:new_subunit]).sample.click
multipliers = [
"a", # * not a number (NaN)
"1e#{Float::MAX_10_EXP + 1}", # * value too big (Infinity)
# * value too big (> max), N/A
"-1e#{Float::MAX_10_EXP + 1}", # * value too small (-Infinity)
"-1", # * value too small (< min)
"0", # * -"-
"1." + "0" * (Float::DIG - 1) + "1", # * precision too big
"1" + "0" * (Float::DIG - 1) + "1", # * -"-
"0.1" + "0" * (Float::DIG - 1) + "1", # * -"-
"1e#{Float::MIN_10_EXP - Float::DIG - 1}", # * precision too big (MIN > value > 0)
]
field = find(:table_cell, column(:multiplier), fillable: true).find_field
assert_not_matches_selector field, ':invalid'
multipliers.shuffle.each do |multiplier|
field.fill_in with: multiplier
assert_matches_selector field, ':invalid'
end
end
test "create updates view in order" do
# Destroy and re-create unit to verify its index position is unchanged.
# NOTE: does this test add anything over "new and create"?
sign_in(user: users.select { |u| u.confirmed? && u.units.many? }.sample)
link = all(:link_or_button, exact_text: t('units.unit.destroy')).sample
symbol = link.ancestor('tr').first(:link).text
index = link.ancestor('tbody').all('tr').index { |e| e.first(:link).text == symbol }
unit = @user.units.find_by(symbol: symbol)
link.click
assert_selector '.flash.notice'
if unit.base_id?
find_link(unit.base.symbol).ancestor('tr').click_on(t('units.unit.new_subunit'))
fill_in 'unit[multiplier]', with: unit.multiplier
else
click_on t('units.index.new_unit')
end
fill_in 'unit[symbol]', with: unit.symbol
click_on t('helpers.submit.create')
within "tbody > tr:nth-child(#{index+1})" do
assert_selector :link, exact_text: symbol
end
end
test "create and update on validation error" do
# Require at least 1 unit to be able to try and create unit with duplicate symbol.
sign_in(user: users.select { |u| u.confirmed? && !u.units.empty? }.sample)
symbols = list_symbols
# It's impossible to cause validation error on :edit with single unit.
link_labels.delete(:edit) unless @user.units.many?
action, label = link_labels.to_a.sample
link = all(:link, exact_text: label).sample
link.click
get_values = ->{ all(:field).map { |f| [f[:name], f.value] }.to_h }
values = nil
within :table_row, {}, with_focus: true do
# Provide duplicate :symbol as server-side invalidated input.
field = find(:table_cell, column(:symbol)).find(:fillable_field)
field.fill_in with: (symbols - [field.value]).sample
values = get_values[]
send_keys :enter
end
assert_selector '.flash.alert',
text: t('activerecord.errors.models.unit.attributes.symbol.taken')
if action == :edit
assert_no_selector :link, exact_text: link[:text]
else
assert_matches_selector link, :link, disabled: true
end
within :table_row, {}, with_focus: true do
assert_equal values, get_values[]
click_on t(:cancel)
end
assert_no_selector '.flash.alert'
assert_equal symbols, list_symbols
refresh
assert_equal symbols, list_symbols
end
test "new and edit allow opening multiple forms" do
# Require at least 1 unit to be able to open 2 forms.
sign_in(user: users.select { |u| u.confirmed? && !u.units.empty? }.sample)
links = link_labels.transform_values do |labels|
all(:link, exact_text: labels).to_a
end
random_link = ->{ links.transform_values(&:sample).compact.to_a.sample }
# Define <tr> count change depending on link clicked.
tr_diff = {new_unit: 1, new_subunit: 1, edit: 0}
action, link = random_link[].tap { |t, l| links[t].delete(l) }
subunit_link = link.ancestor('tr')
.first(:link, link_labels[:new_subunit], between: 0..1) if action == :edit
assert_difference ->{ all('tbody tr').count }, tr_diff[action] do
assert_difference ->{ all('tbody tr:has(input[type=text])').count }, 1 do
link.click
end
end
form = find('tbody tr:has(input:focus)')
if action == :edit
refute link.visible?
refute subunit_link&.visible?
links[:new_subunit].delete(subunit_link)
else
assert_matches_selector link, :link, disabled: true
end
action, link = random_link[]
assert_difference ->{ all('tbody tr').count }, tr_diff[action] do
assert_difference ->{ all('tbody tr:has(input[type=text])').count }, 1 do
link.click
end
end
assert_not_equal form, find('tbody tr:has(input:focus)')
end
test "edit" do
# NOTE: Check if displayed attributes match record
assert true
end
# NOTE: extend with any add/edit link
test "new form closes on escape key" do
sign_in
click_on t('units.index.new_unit')
first('tbody > tr').all(:field).sample.send_keys :escape
within 'tbody' do
assert_no_selector :fillable_field
end
end
# NOTE: extend with any add/edit link
test "new form can be reopened after close" do
sign_in
click_on t('units.index.new_unit')
within 'tbody' do
find(:link_or_button, exact_text: t(:cancel)).click
assert_no_selector :fillable_field
end
click_on t('units.index.new_unit')
assert_selector 'tbody > tr:has(input, textarea)'
end
test "rebase" do
# TODO
assert true
end
test "destroy" do
sign_in(user: users.select { |u| u.confirmed? && !u.units.empty? }.sample)
while button = all(:button, exact_text: t('units.unit.destroy')).sample
symbol = button.ancestor(:table_row, {}).find(:table_cell, column(:symbol)).text
assert_changes ->{ list_symbols }, to: list_symbols - [symbol] do
button.click
assert_selector '.flash.notice', text: t('units.destroy.success', unit: symbol)
end
end
assert_selector :table, rows: [[t('units.no_items')]]
refresh
assert_selector :table, rows: [[t('units.no_items')]]
end
end