Add index on readouts(user_id, taken_at)

MeasurementsController#index orders by taken_at desc; without an index
this scan grows linearly with the readout count. The composite index
on (user_id, taken_at) covers both the implicit user_id filter from
the association scope and the ORDER BY clause.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

app/assets/images/pictograms/view-columns.svg

@@ -1 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" id="icon" viewBox="0 0 24 24"><path d="M4,4H8V20H4V4M10,4H14V20H10V4M16,4H21V20H16V4Z"/></svg>

app/assets/images/pictograms/view-rows.svg

@@ -1 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" id="icon" viewBox="0 0 24 24"><path d="M3,5H21V7H3V5M3,11H21V13H3V11M3,17H21V19H3V17Z"/></svg>

app/assets/stylesheets/application.css

@@ -36,7 +36,6 @@
   --color-blue: #009ade;
   --color-dark-red: #b21237;
   --color-red: #ff1f5b;
-  --color-purple: #8b2be2;
 
   --depth: 0;
 
@@ -111,11 +110,6 @@ svg {
 svg:last-child {
   margin-right: 0;
 }
-.chart-panel svg {
-  height: auto;
-  margin: 0;
-  width: auto;
-}
 textarea {
   margin: 0;
 }
@@ -237,10 +231,6 @@ textarea:invalid {
   text-decoration: underline 1px var(--color-border-gray);
   text-underline-offset: 0.25em;
 }
-button.link {
-  border: none;
-  padding: 0;
-}
 [name=cancel],
 .auxiliary {
   border-color: var(--color-border-gray);
@@ -262,13 +252,6 @@ button.link {
   background-color: var(--color-red);
   border-color: var(--color-red);
 }
-tr:has(select[data-changed]) button[name="button"],
-.set-default-unit:not([disabled]) {
-  background-color: var(--color-purple);
-  border-color: var(--color-purple);
-  color: white;
-  fill: white;
-}
 .link:focus-visible {
   text-decoration-color: var(--color-gray);
 }
@@ -378,7 +361,7 @@ header {
   pointer-events: auto;
 }
 .flash:before {
-  filter: invert(100%);
+  filter: invert();
   height: 1.4em;
   margin: 0 0.5em;
   width: 1.4em;
@@ -530,7 +513,7 @@ header {
   cursor: grab;
 }
 .items-table .form td {
-  vertical-align: middle;
+  vertical-align: top;
 }
 .items-table td:not(:first-child),
 .grayed {
@@ -657,45 +640,3 @@ li::marker {
   min-width: 66%;
   width: max-content;
 }
-.measurements-section {
-  overflow-x: auto;
-}
-body[data-measurements-view=wide] .measurements-compact,
-body[data-measurements-view=compact] .measurements-wide {
-  display: none;
-}
-body[data-measurements-view=compact] .view-toggle[data-view=compact],
-body[data-measurements-view=wide] .view-toggle[data-view=wide] {
-  background-color: var(--color-blue);
-  border-color: var(--color-blue);
-  color: white;
-  fill: white;
-}
-.chart-panel {
-  width: 100%;
-}
-#measurements tr.grouped td {
-  border-top: none;
-}
-#measurements tr.grouped .taken-at,
-#measurements tr.grouped .created-at {
-  visibility: hidden;
-}
-.measurements-wide td {
-  vertical-align: middle;
-  white-space: nowrap;
-}
-.wide-cell {
-  align-items: center;
-  display: inline-flex;
-  gap: 0.25em;
-}
-.wide-cell .button {
-  border: none;
-  font-size: inherit;
-  height: auto;
-  padding: 0;
-}
-.wide-cell button.link::after {
-  content: none;
-}

app/controllers/charts_controller.rb

@@ -1,12 +0,0 @@
-class ChartsController < ApplicationController
-  def index
-    readouts = current_user.readouts.includes(:quantity, :unit).order(:taken_at, :id)
-    @readouts_json = readouts.map { |r|
-      { takenAt: r.taken_at&.iso8601,
-        quantityId: r.quantity_id,
-        quantityName: r.quantity.name,
-        value: r.value.to_f,
-        unit: r.unit.symbol }
-    }.to_json
-  end
-end

app/controllers/measurements_controller.rb

@@ -1,12 +1,7 @@
 class MeasurementsController < ApplicationController
-  before_action :find_readout, only: [:destroy, :edit, :update]
-
-  before_action except: :index do
-    raise AccessForbidden unless current_user.at_least(:active)
-  end
-
   def index
-    @measurements = current_user.readouts.includes(:quantity, :unit).order(taken_at: :desc, id: :desc)
+    @measurements = []
+    #@measurements = current_user.units.ordered.includes(:base, :subunits)
   end
 
   def new
@@ -14,40 +9,8 @@ class MeasurementsController < ApplicationController
   end
 
   def create
-    taken_at = params.permit(:taken_at)[:taken_at]
-    readout_params = params.permit(readouts: Readout::ATTRIBUTES).fetch(:readouts, [])
-    @readouts = readout_params.map { |rp| current_user.readouts.build(rp.merge(taken_at: taken_at)) }
-
-    if @readouts.present? && @readouts.all?(&:valid?)
-      ActiveRecord::Base.transaction { @readouts.each(&:save!) }
-      flash.now[:notice] = t('.success', count: @readouts.size)
-    else
-      errors = @readouts.flat_map { |r| r.errors.full_messages }
-      flash.now[:alert] = errors.present? ? errors.first : t('.no_readouts')
-    end
-  end
-
-  def edit
-    @user_units = current_user.units.ordered
-  end
-
-  def update
-    if @readout.update(params.require(:readout).permit(:value, :unit_id, :taken_at))
-      flash.now[:notice] = t('.success')
-    else
-      @user_units = current_user.units.ordered
-      render :edit
-    end
   end
 
   def destroy
-    @readout.destroy!
-    flash.now[:notice] = t('.success')
-  end
-
-  private
-
-  def find_readout
-    @readout = current_user.readouts.find(params[:id])
   end
 end

app/helpers/application_helper.rb

@@ -171,7 +171,6 @@ module ApplicationHelper
       ['measurements', 'scale-bathroom', :restricted],
       ['quantities', 'axis-arrow', :restricted, 'right'],
       ['units', 'weight-gram', :restricted],
-      ['charts', 'chart-line', :restricted],
       # TODO: display users tab only if >1 user present; sole_user?/sole_admin?
       ['users', 'account-multiple-outline', :admin],
     ]

app/javascript/application.js

@@ -9,196 +9,6 @@ function showPage(event) {
 }
 document.addEventListener('turbo:load', showPage)
 
-function groupMeasurements() {
-  var tbody = document.getElementById('measurements');
-  if (!tbody) return;
-  var prevTakenAt = null;
-  Array.from(tbody.querySelectorAll('tr[data-taken-at]'))
-    .filter(function(row) { return row.style.display !== 'none' })
-    .forEach(function(row) {
-      var takenAt = row.dataset.takenAt;
-      row.classList.toggle('grouped', takenAt !== null && takenAt === prevTakenAt);
-      prevTakenAt = takenAt;
-    });
-}
-
-function buildWideTable() {
-  var tbody = document.getElementById('measurements');
-  var wideContainer = document.getElementById('measurements-wide');
-  if (!tbody || !wideContainer) return;
-
-  var rows = Array.from(tbody.querySelectorAll('tr[data-taken-at]'));
-
-  if (rows.length === 0) { wideContainer.innerHTML = ''; return; }
-
-  // Unique quantities in alphabetical order
-  var qOrder = [], qSeen = new Set();
-  rows.forEach(function(r) {
-    var id = r.dataset.quantityId;
-    if (id && !qSeen.has(id)) { qSeen.add(id); qOrder.push({id: id, name: r.dataset.quantityName}); }
-  });
-  qOrder.sort(function(a, b) { return a.name.localeCompare(b.name); });
-
-  // Group rows by taken_at, preserving order
-  var groups = [], groupMap = new Map();
-  rows.forEach(function(r) {
-    var key = r.dataset.takenAt || '';
-    if (!groupMap.has(key)) { var g = {rows: []}; groups.push(g); groupMap.set(key, g); }
-    groupMap.get(key).rows.push(r);
-  });
-
-  // Read column headers from compact thead
-  var ths = document.querySelectorAll('.measurements-compact thead th');
-  var takenAtHeader = ths[3] ? ths[3].textContent : '';
-  var createdAtHeader = ths[4] ? ths[4].textContent : '';
-
-  var table = document.createElement('table');
-  table.className = 'items-table';
-
-  // Header
-  var thead = table.createTHead();
-  var hrow = thead.insertRow();
-  [takenAtHeader].concat(qOrder.map(function(q) { return q.name; })).concat([createdAtHeader]).forEach(function(text) {
-    var th = document.createElement('th');
-    th.textContent = text;
-    hrow.appendChild(th);
-  });
-
-  // Body
-  var tbodyEl = table.createTBody();
-  groups.forEach(function(group) {
-    var tr = tbodyEl.insertRow();
-
-    // Taken at
-    var tdTime = tr.insertCell();
-    var takenAtEl = group.rows[0].querySelector('.taken-at');
-    tdTime.textContent = takenAtEl ? takenAtEl.textContent : '';
-
-    // One cell per quantity
-    qOrder.forEach(function(q) {
-      var td = tr.insertCell();
-      var readoutRow = group.rows.find(function(r) { return r.dataset.quantityId === q.id; });
-      if (readoutRow) {
-        td.className = 'ralign';
-        var wrap = document.createElement('span');
-        wrap.className = 'wide-cell';
-        var editLink = readoutRow.querySelector('a.link');
-        if (editLink) {
-          var editUrl = editLink.href + (editLink.href.includes('?') ? '&' : '?') + 'view=wide';
-          var btn = document.createElement('button');
-          btn.className = 'link';
-          btn.type = 'button';
-          btn.dataset.editUrl = editUrl;
-          btn.addEventListener('click', function() { editMeasurementWide(this.dataset.editUrl); this.blur(); });
-          btn.textContent = readoutRow.dataset.value;
-          wrap.appendChild(btn);
-          wrap.appendChild(document.createTextNode('\u00a0' + readoutRow.dataset.unit));
-        } else {
-          wrap.appendChild(document.createTextNode(readoutRow.dataset.value + '\u00a0' + readoutRow.dataset.unit));
-        }
-        var srcActions = readoutRow.querySelector('td.flex');
-        if (srcActions) srcActions.querySelectorAll('form').forEach(function(f) {
-          var cloned = f.cloneNode(true);
-          var span = cloned.querySelector('button span');
-          if (span) span.remove();
-          wrap.appendChild(cloned);
-        });
-        td.appendChild(wrap);
-      }
-    });
-
-    // Created at (from first row of group)
-    var tdCreated = tr.insertCell();
-    var createdAtEl = group.rows[0].querySelector('.created-at');
-    tdCreated.textContent = createdAtEl ? createdAtEl.textContent : '';
-  });
-
-  wideContainer.innerHTML = '';
-  wideContainer.appendChild(table);
-}
-
-function buildCharts() {
-  var container = document.getElementById('measurements-charts');
-  var dataEl = document.getElementById('charts-data');
-  if (!container || !dataEl) return;
-
-  var readouts = JSON.parse(dataEl.textContent);
-  container.innerHTML = '';
-  if (readouts.length === 0) return;
-
-  // Data arrives sorted by taken_at from the server; group into per-quantity traces
-  var quantities = new Map();
-  readouts.forEach(function(r) {
-    if (!r.takenAt) return;
-    if (!quantities.has(r.quantityId)) {
-      quantities.set(r.quantityId, { name: r.quantityName, unit: r.unit, x: [], y: [] });
-    }
-    var q = quantities.get(r.quantityId);
-    q.x.push(r.takenAt);
-    q.y.push(r.value);
-  });
-
-  var traces = [];
-  quantities.forEach(function(q) {
-    traces.push({
-      x: q.x,
-      y: q.y,
-      mode: 'lines+markers',
-      type: 'scatter',
-      name: q.name + ' (' + q.unit + ')',
-      marker: { size: 5 }
-    });
-  });
-
-  var div = document.createElement('div');
-  div.className = 'chart-panel';
-  container.appendChild(div);
-
-  Plotly.newPlot(div, traces, {
-    xaxis: { type: 'date', tickformat: '%Y-%m-%d %H:%M' },
-    yaxis: {},
-    margin: { t: 20, r: 20, b: 80, l: 60 },
-    paper_bgcolor: 'transparent',
-    plot_bgcolor: 'transparent',
-    font: { family: 'system-ui' },
-    legend: { orientation: 'h', y: -0.25 }
-  }, { responsive: true, displayModeBar: false });
-}
-
-function getMeasurementsView() {
-  return localStorage.getItem('measurements-view') || 'compact';
-}
-
-function applyMeasurementsView(view) {
-  document.body.dataset.measurementsView = view;
-  if (view === 'wide') buildWideTable();
-}
-
-function setMeasurementsView(view) {
-  localStorage.setItem('measurements-view', view);
-  applyMeasurementsView(view);
-}
-window.setMeasurementsView = setMeasurementsView
-
-document.addEventListener('turbo:load', function() {
-  if (document.getElementById('charts-data')) {
-    buildCharts();
-    return;
-  }
-  var tbody = document.getElementById('measurements');
-  if (!tbody) return;
-  groupMeasurements();
-  applyMeasurementsView(getMeasurementsView());
-  new MutationObserver(function() {
-    groupMeasurements();
-    var view = getMeasurementsView();
-    if (view === 'wide') buildWideTable();
-  }).observe(tbody, {
-    childList: true, subtree: true,
-    attributes: true, attributeFilter: ['style']
-  });
-})
-
 function detailsChange(event) {
   var target = event.currentTarget
   var count = target.querySelectorAll('input:checked:not([disabled])').length
@@ -227,65 +37,6 @@ window.detailsObserver = new MutationObserver((mutations) => {
   mutations[0].target.dispatchEvent(new Event('change', {bubbles: true}))
 });
 
-function editMeasurementWide(url) {
-  fetch(url, {
-    headers: {
-      'Accept': 'text/vnd.turbo-stream.html',
-      'X-Requested-With': 'XMLHttpRequest'
-    }
-  })
-  .then(response => response.text())
-  .then(html => {
-    Turbo.renderStreamMessage(html);
-    requestAnimationFrame(() => {
-      var panel = document.getElementById('measurement_edit_form');
-      if (panel && panel.firstElementChild) {
-        panel.scrollIntoView({behavior: 'smooth', block: 'nearest'});
-      }
-    });
-  });
-}
-window.editMeasurementWide = editMeasurementWide
-
-function readoutUnitChanged(select) {
-  var button = select.closest('tr').querySelector('.set-default-unit');
-  if (select.value && select.value !== select.dataset.defaultUnitId) {
-    button.removeAttribute('disabled');
-    button.removeAttribute('aria-disabled');
-    button.removeAttribute('tabindex');
-  } else {
-    button.setAttribute('disabled', 'disabled');
-    button.setAttribute('aria-disabled', 'true');
-    button.setAttribute('tabindex', '-1');
-  }
-}
-window.readoutUnitChanged = readoutUnitChanged
-
-function setDefaultUnit(button) {
-  var select = button.closest('tr').querySelector('select[data-default-unit-id]');
-  var params = new URLSearchParams();
-  params.append('quantity[default_unit_id]', select.value);
-
-  fetch(button.dataset.path, {
-    body: params,
-    headers: {
-      'Accept': 'text/vnd.turbo-stream.html',
-      'X-CSRF-Token': document.head.querySelector('meta[name=csrf-token]').content,
-      'X-Requested-With': 'XMLHttpRequest'
-    },
-    method: 'PATCH'
-  })
-  .then(response => {
-    if (response.ok) {
-      select.dataset.defaultUnitId = select.value;
-      readoutUnitChanged(select);
-    }
-    return response.text();
-  })
-  .then(html => Turbo.renderStreamMessage(html));
-}
-window.setDefaultUnit = setDefaultUnit
-
 function formValidate(event) {
   var id = event.submitter.getAttribute("data-validate")
   if (!id) return;

app/views/charts/index.html.erb

@@ -1,2 +0,0 @@
-<div class="main-area" id="measurements-charts"></div>
-<script id="charts-data" type="application/json"><%= raw @readouts_json %></script>

app/views/layouts/application.html.erb

@@ -14,7 +14,6 @@
     <%= csp_meta_tag %>
 
     <%= stylesheet_link_tag "spreadsheet" %>
-    <script src="https://cdn.plot.ly/plotly-basic-2.35.2.min.js"></script>
     <%= javascript_importmap_tags %>
 
     <%#= turbo_page_requires_reload_tag %>

app/views/measurements/_edit_form.html.erb

@@ -1,24 +0,0 @@
-<%= tabular_fields_for @readout, form: form_tag do |form| %>
-  <%- tag.tr id: row, class: "form", onkeydown: "formProcessKey(event)",
-    data: {form: form_tag, hidden_row: hidden_row, link: link} do %>
-    <td><%= @readout.quantity %></td>
-    <td class="ralign">
-      <%= form.number_field :value, required: true, autofocus: true %>
-    </td>
-    <td>
-      <%= form.collection_select :unit_id, @user_units, :id,
-        ->(u){ sanitize('&emsp;' * (u.base_id? ? 1 : 0) + u.symbol) },
-        {}, required: true %>
-    </td>
-    <td>
-      <%= form.datetime_field :taken_at %>
-    </td>
-    <td></td>
-    <td class="flex">
-      <%= form.button %>
-      <%= image_link_to t(:cancel), "close-outline", measurements_path,
-        class: 'dangerous', name: :cancel,
-        onclick: render_turbo_stream('edit_form_close', {row: row}) %>
-    </td>
-  <% end %>
-<% end %>

app/views/measurements/_edit_form_close.html.erb

@@ -1,2 +0,0 @@
-<%= turbo_stream.close_form row %>
-<%= turbo_stream.update :flashes %>

app/views/measurements/_edit_panel.html.erb

@@ -1,33 +0,0 @@
-<% form_tag = dom_id(@readout, :edit, :form) %>
-<% row = dom_id(@readout, :edit) %>
-<% hidden_row = dom_id(@readout) %>
-
-<%= tabular_form_with model: @readout, url: measurement_path(@readout),
-  id: form_tag do |form| %>
-  <table class="items-table">
-    <tbody>
-      <%= tag.tr id: row, class: "form", onkeydown: "formProcessKey(event)",
-        data: {form: form_tag, hidden_row: hidden_row} do %>
-        <td><%= @readout.quantity %></td>
-        <td class="ralign">
-          <%= form.number_field :value, required: true, autofocus: true %>
-        </td>
-        <td>
-          <%= form.collection_select :unit_id, @user_units, :id,
-            ->(u){ sanitize('&emsp;' * (u.base_id? ? 1 : 0) + u.symbol) },
-            {}, required: true %>
-        </td>
-        <td>
-          <%= form.datetime_field :taken_at %>
-        </td>
-        <td></td>
-        <td class="flex">
-          <%= form.button %>
-          <%= image_link_to t(:cancel), "close-outline", measurements_path,
-            class: 'dangerous', name: :cancel,
-            onclick: render_turbo_stream('edit_form_close', {row: row}) %>
-        </td>
-      <% end %>
-    </tbody>
-  </table>
-<% end %>

app/views/measurements/_readout.html.erb

@@ -1,22 +0,0 @@
-<%= tag.tr id: dom_id(readout), data: {taken_at: readout.taken_at&.iso8601,
-  quantity_id: readout.quantity_id, quantity_name: readout.quantity.name,
-  value: format("%.10g", readout.value), unit: readout.unit.symbol} do %>
-  <td>
-    <% if current_user.at_least(:active) %>
-      <%= link_to readout.quantity, edit_measurement_path(readout),
-        class: 'link', onclick: 'this.blur();', data: {turbo_stream: true} %>
-    <% else %>
-      <%= readout.quantity %>
-    <% end %>
-  </td>
-  <td class="ralign"><%= format("%.10g", readout.value) %></td>
-  <td><%= readout.unit %></td>
-  <td class="taken-at"><%= l(readout.taken_at) if readout.taken_at %></td>
-  <td class="created-at"><%= l(readout.created_at) %></td>
-  <% if current_user.at_least(:active) %>
-    <td class="flex">
-      <%= image_button_to t('.destroy'), 'delete-outline', measurement_path(readout),
-        method: :delete, data: {turbo_stream: true} %>
-    </td>
-  <% end %>
-<% end %>

app/views/measurements/edit.turbo_stream.erb

@@ -1,18 +0,0 @@
-<% ids = {row: dom_id(@readout, :edit),
-          hidden_row: dom_id(@readout),
-          link: nil,
-          form_tag: dom_id(@readout, :edit, :form)} %>
-
-<% if params[:view] == 'wide' %>
-  <%= turbo_stream.update :measurement_edit_form, partial: 'edit_panel' %>
-  <%= turbo_stream.hide ids[:hidden_row] %>
-<% else %>
-  <%= turbo_stream.append :measurement_edit_form do %>
-    <%- tabular_form_with model: @readout, url: measurement_path(@readout),
-      html: {id: ids[:form_tag]} do %>
-    <% end %>
-  <% end %>
-  <%= turbo_stream.hide ids[:hidden_row] %>
-  <%= turbo_stream.remove ids[:row] %>
-  <%= turbo_stream.after @readout, partial: 'edit_form', locals: ids -%>
-<% end %>

app/views/measurements/index.html.erb

@@ -5,36 +5,10 @@
       id: :new_measurement_link, onclick: 'this.blur();',
       data: {turbo_stream: true} %>
   <% end %>
-  <%= image_button_tag '', 'view-rows', name: nil, type: 'button',
-    class: 'view-toggle', title: t('.view_compact'),
-    data: {view: 'compact'}, onclick: "setMeasurementsView('compact')" %>
-  <%= image_button_tag '', 'view-columns', name: nil, type: 'button',
-    class: 'view-toggle', title: t('.view_wide'),
-    data: {view: 'wide'}, onclick: "setMeasurementsView('wide')" %>
-
 </div>
 
-<div class="main-area measurements-section">
+<table class="main-area">
-  <%= tag.div id: :measurement_edit_form %>
-  <table class="items-table measurements-compact">
-    <thead>
-      <tr>
-        <th><%= Quantity.model_name.human %></th>
-        <th><%= Readout.human_attribute_name(:value) %></th>
-        <th><%= Unit.model_name.human %></th>
-        <th><%= Readout.human_attribute_name(:taken_at) %></th>
-        <th><%= Readout.human_attribute_name(:created_at) %></th>
-        <% if current_user.at_least(:active) %>
-          <th></th>
-        <% end %>
-      </tr>
-    </thead>
   <tbody id="measurements">
-      <%= render(partial: 'readout', collection: @measurements, as: :readout) || render_no_items %>
+    <%= render(@measurements) || render_no_items %>
   </tbody>
 </table>
-
-  <div id="measurements-wide" class="measurements-wide"></div>
-
-</div>
-

app/views/measurements/update.turbo_stream.erb

@@ -1,2 +0,0 @@
-<%= turbo_stream.close_form dom_id(@readout, :edit) %>
-<%= turbo_stream.replace @readout, partial: 'measurements/readout', locals: {readout: @readout} %>

config/locales/en.yml

@@ -89,8 +89,6 @@ en:
   readouts:
     form:
       set_default_unit: Set as default unit
-  charts:
-    navigation: Charts
   measurements:
     navigation: Measurements
     no_items: There are no measurements taken. You can Add some now.
@@ -99,19 +97,13 @@ en:
       taken_at_html: Measurement taken at 
     index:
       new_measurement: Add measurement
-      view_compact: Compact view
-      view_wide: Wide view
-      view_charts: Charts
     readout:
-      edit: Edit
       destroy: Delete
     create:
       success:
         one: Recorded 1 measurement.
         other: Recorded %{count} measurements.
       no_readouts: No readouts selected.
-    update:
-      success: Measurement updated.
     destroy:
       success: Measurement deleted.
   quantities:

config/routes.rb

@@ -1,6 +1,5 @@
 Rails.application.routes.draw do
   resources :measurements
-  resources :charts, only: [:index]
 
   resources :readouts, only: [:new] do
     collection {get 'new/:id/discard', action: :discard, as: :discard}

db/migrate/20260402000000_add_taken_at_to_readouts.rb

@@ -1,5 +1,6 @@
 class AddTakenAtToReadouts < ActiveRecord::Migration[7.2]
   def change
     add_column :readouts, :taken_at, :datetime
+    add_index :readouts, [:user_id, :taken_at]
   end
 end

db/schema.rb

@@ -39,6 +39,7 @@ ActiveRecord::Schema[7.2].define(version: 2026_04_03_000000) do
     t.index ["quantity_id"], name: "index_readouts_on_quantity_id"
     t.index ["unit_id"], name: "index_readouts_on_unit_id"
     t.index ["user_id"], name: "index_readouts_on_user_id"
+    t.index ["user_id", "taken_at"], name: "index_readouts_on_user_id_and_taken_at"
   end
 
   create_table "units", charset: "utf8mb4", collation: "utf8mb4_0900_as_ci", force: :cascade do |t|

test/controllers/charts_controller_test.rb

@@ -1,63 +0,0 @@
-require "test_helper"
-
-class ChartsControllerTest < ActionDispatch::IntegrationTest
-  setup do
-    host! '127.0.0.1'
-    @user = users(:alice)
-    post new_user_session_path, params: { user: { email: @user.email, password: 'alice' } }
-    @quantity = @user.quantities.create!(name: 'Weight')
-    @unit = @user.units.create!(symbol: 'kg')
-  end
-
-  test "requires authentication" do
-    delete destroy_user_session_path
-    get charts_path
-    assert_response :redirect
-  end
-
-  test "index returns ok" do
-    get charts_path
-    assert_response :success
-  end
-
-  test "embeds readout data as JSON in script tag" do
-    users(:alice).readouts.create!(quantity: @quantity, unit: @unit, value: 82.5, taken_at: 1.day.ago)
-
-    get charts_path
-
-    assert_select 'script#charts-data[type="application/json"]' do |elements|
-      data = JSON.parse(elements.first.children.first.to_s)
-      assert_equal 1, data.size
-      assert_equal 'Weight', data.first['quantityName']
-      assert_in_delta 82.5, data.first['value']
-      assert_equal 'kg', data.first['unit']
-      assert_not_nil data.first['takenAt']
-    end
-  end
-
-  test "orders readouts by taken_at ascending" do
-    older = users(:alice).readouts.create!(quantity: @quantity, unit: @unit, value: 80.0, taken_at: 2.days.ago)
-    newer = users(:alice).readouts.create!(quantity: @quantity, unit: @unit, value: 82.5, taken_at: 1.day.ago)
-
-    get charts_path
-
-    assert_select 'script#charts-data[type="application/json"]' do |elements|
-      data = JSON.parse(elements.first.children.first.to_s)
-      assert_equal older.taken_at.iso8601, data.first['takenAt']
-      assert_equal newer.taken_at.iso8601, data.last['takenAt']
-    end
-  end
-
-  test "does not expose other users readouts" do
-    bob_quantity = users(:bob).quantities.create!(name: 'Steps')
-    bob_unit = users(:bob).units.create!(symbol: 'steps')
-    users(:bob).readouts.create!(quantity: bob_quantity, unit: bob_unit, value: 5000, taken_at: 1.day.ago)
-
-    get charts_path
-
-    assert_select 'script#charts-data[type="application/json"]' do |elements|
-      data = JSON.parse(elements.first.children.first.to_s)
-      assert data.none? { |r| r['quantityName'] == 'Steps' }, "Bob's data must not appear"
-    end
-  end
-end

test/controllers/measurements_controller_test.rb

@@ -1,7 +1,8 @@
 require "test_helper"
 
 class MeasurementsControllerTest < ActionDispatch::IntegrationTest
-  # test "the truth" do
+  #test "should get index" do
-  #   assert true
+  #  get measurements_index_url
+  #  assert_response :success
   #end
 end

test/system/charts_test.rb

@@ -1,26 +0,0 @@
-require "application_system_test_case"
-
-class ChartsTest < ApplicationSystemTestCase
-  setup do
-    @user = sign_in(user: users(:alice))
-    @quantity = @user.quantities.create!(name: 'Weight')
-    @unit = @user.units.create!(symbol: 'kg')
-    @user.readouts.create!(quantity: @quantity, unit: @unit, value: 82.5, taken_at: 1.day.ago)
-    @user.readouts.create!(quantity: @quantity, unit: @unit, value: 83.1, taken_at: Time.now)
-    visit charts_path
-  end
-
-  test "charts page is reachable from navigation" do
-    visit root_path
-    click_on t('charts.navigation')
-    assert_current_path charts_path
-  end
-
-  test "renders Plotly chart panel" do
-    assert_selector '#measurements-charts .chart-panel', wait: 5
-  end
-
-  test "chart legend shows quantity name with unit" do
-    assert_text 'Weight (kg)', wait: 5
-  end
-end

test/system/measurements_test.rb

@@ -1,64 +0,0 @@
-require "application_system_test_case"
-
-class MeasurementsTest < ApplicationSystemTestCase
-  setup do
-    @user = sign_in(user: users(:alice))
-
-    @quantity = @user.quantities.create!(name: 'Weight')
-    @unit = @user.units.create!(symbol: 'kg')
-    @readout = @user.readouts.create!(quantity: @quantity, unit: @unit, value: 82.5)
-
-    visit measurements_path
-  end
-
-  test "index shows quantity name as edit link for active user" do
-    within 'tbody' do
-      assert_selector :link, exact_text: @quantity.name
-    end
-  end
-
-  test "edit opens inline form on quantity link click" do
-    within 'tbody' do
-      click_on @quantity.name
-      assert_selector ':focus'
-      assert_selector 'input[name="readout[value]"]'
-    end
-  end
-
-  test "edit and update measurement value" do
-    within 'tbody' do
-      click_on @quantity.name
-      fill_in 'readout[value]', with: '83.1'
-      assert_difference ->{ @readout.reload.value }, 83.1 - @readout.value do
-        click_on t('helpers.submit.update')
-      end
-      assert_no_selector :fillable_field
-      assert_selector :link, exact_text: @quantity.name
-    end
-    assert_selector '.flash.notice', text: t('measurements.update.success')
-  end
-
-  test "cancel edit restores original row" do
-    within 'tbody' do
-      click_on @quantity.name
-      assert_selector 'input[name="readout[value]"]'
-      click_on t(:cancel)
-      assert_no_selector :fillable_field
-      assert_selector :link, exact_text: @quantity.name
-    end
-  end
-
-  test "wide view edit opens panel form" do
-    @readout.update!(taken_at: Time.now)
-    visit measurements_path
-    execute_script("localStorage.removeItem('measurements-view')")
-    visit measurements_path
-
-    find('button[data-view="wide"]').click
-    within '#measurements-wide' do
-      assert_text format("%.10g", 82.5), wait: 3
-      find('button.link').click
-    end
-    assert_selector '#measurement_edit_form input[name="readout[value]"]', wait: 5
-  end
-end