Check for out of range float values

Remove unsupported attribute `[maxlength]` from `input[number]`.

.gitignore

@@ -15,6 +15,9 @@
 /config/master.key
 /config/puma.rb
 
+# Ignore test database.
+/db/test.sqlite3
+
 # Ignore all logfiles and tempfiles.
 /log/*
 /tmp/*
@@ -30,7 +33,7 @@
 
 /tmp/restart.txt
 
-# Ignore user files
+# Ignore user files.
 /.bash_history
 /.byebug_history
 /.config
@@ -38,6 +41,7 @@
 /.lesshst
 /.local
 /.mysql_history
+/.sqlite_history
 /.ssh
 /.vim
 /.viminfo

CLAUDE.md

@@ -1,106 +0,0 @@
-# CLAUDE.md
-
-This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
-
-## Project Overview
-
-Fixin.me is a "quantified self" Rails 7.2.3 application for personal data tracking. Users define hierarchical **quantities** (metrics to track), **units** (with optional conversion hierarchies), and **readouts** (individual measurements). There is also a non-persistent **measurement** model used as a form wrapper.
-
-## Setup
-
-Configuration files are distributed as `.dist` templates — copy and customize before use:
-
-```bash
-cp config/application.rb.dist config/application.rb
-cp config/database.yml.dist config/database.yml
-cp config/puma.rb.dist config/puma.rb
-```
-
-```bash
-bundle config --local frozen true
-bundle config --local path .gem
-bundle config --local with mysql development test   # or: pg, sqlite
-bundle install
-RAILS_ENV=development bundle exec rails db:create db:migrate db:seed
-```
-
-## Common Commands
-
-```bash
-bundle exec rails s                                          # start server
-bundle exec rails test                                       # all unit/model/controller tests
-bundle exec rails test:system                                # all system tests (Capybara + Selenium)
-bundle exec rails test test/system/units_test.rb            # single test file
-bundle exec rails test --seed 64690 --name test_add_unit    # single test by name
-bundle exec rails db:seed:export                             # export default settings as seed file
-```
-
-## Architecture
-
-### Data Model
-
-- **Quantity** — hierarchical tree (self-referential `parent_id`). Cached `depth` and `pathname` fields are recomputed via recursive CTEs on write. Direct assignment to cached fields is blocked.
-- **Unit** — optional hierarchy via `base_id` and `multiplier` for unit conversion. Multiplier precision/scale is validated by a custom validator.
-- **Readout** — single measurement: `value` (IEEE 754 float), `quantity`, `unit`, `category`.
-- **Measurement** — `ActiveModel::Model` form wrapper (not database-backed); bridges the readout creation form.
-- **User** — Devise-managed with a status enum: `admin`, `active`, `restricted`, `locked`, `disabled`. Admins can disguise as other users.
-
-### Hierarchical Queries
-
-Both `Quantity` and `Unit` use recursive CTEs for tree traversal (ordered traversal, ancestors, progenies, common ancestors). `lib/core_ext/arel/` patches Arel to support CTE with `UPDATE`/`DELETE` statements, working around Rails issue #54658.
-
-### Custom Extensions (`lib/core_ext/`)
-
-- **arel/** — CTE support for UPDATE/DELETE
-- **active_model/** — precision/scale validator used by `Unit#multiplier`
-- **active_record/** — `attr_cached` mechanism (see `ApplicationRecord`)
-- **action_view/** — record identifier suffixes
-- Miscellaneous: `Array#delete_bang`, `BigDecimal` scientific notation
-
-### Response Handling
-
-Controllers respond to both HTML and Turbo Stream formats. Errors during Turbo Stream requests trigger a redirect with flash rather than rendering inline, handled in `ApplicationController`.
-
-### Numeric Precision
-
-Readout values are stored as IEEE 754 double-precision floats (not fixed-point decimals). Rationale in `DESIGN.md`: biological values span many orders of magnitude; 15-digit float precision is sufficient and avoids conversion overhead.
-
-### Routes
-
-```
-measurements   GET/POST /measurements
-readouts       GET/POST /readouts, DELETE /readouts/:id/discard
-quantities     CRUD + POST /quantities/:id/reparent
-units          CRUD + POST /units/:id/rebase
-users          CRUD + POST /users/:id/disguise, POST /users/revert
-default/       namespace for default units import/export and admin panel
-root           → /units (authenticated), /sign_in (unauthenticated)
-```
-
-## JavaScript Conventions
-
-### No manual fetch() — use Turbo
-
-Never make AJAX requests with `fetch()` in JavaScript. Use Turbo's built-in mechanisms instead:
-
-- **Links/buttons that trigger server actions**: use `data: {turbo_stream: true}` on the element (link or button_to form).
-- **Dynamic form submissions from JS** (where HTML alone isn't enough): create a form element, append hidden inputs, and call `form.requestSubmit()`. Turbo intercepts it automatically — no manual CSRF handling, no `Turbo.renderStreamMessage()`.
-  ```javascript
-  var form = document.createElement('form');
-  form.action = url; form.method = 'post'; form.dataset.turboStream = 'true';
-  // append hidden inputs...
-  form.addEventListener('turbo:submit-end', function() { form.remove(); });
-  document.body.appendChild(form);
-  form.requestSubmit();
-  ```
-- **Server-rendered HTML**: use ERB partials and Turbo Stream views (`*.turbo_stream.erb`), never build HTML in JavaScript.
-
-### No HTML generation in JavaScript
-
-Never use JavaScript to build and insert HTML (no `innerHTML =`, no `createElement` trees for content). Render HTML server-side in ERB partials; update the DOM via Turbo Stream actions (`replace`, `update`, `append`, etc.).
-
-## Database Requirements
-
-The database must support:
-- Recursive CTEs with `UPDATE`/`DELETE` (MySQL ≥ 8.0, PostgreSQL, or SQLite3)
-- Decimal precision of 30+ digits

DESIGN.md

@@ -22,13 +22,55 @@ whenever a change is considered, to avoid regressions.
           and scale approximately half of that - 9,
     * double precision floating point guarantees 15 digits of precision, which
       is more than enough for all expected use cases,
+        * if a decimal string with at most 15 significant digits is converted to
+          the IEEE 754 double-precision format, giving a normal number, and then
+          converted back to a decimal string with the same number of digits, the
+          final result should match the original string,
+        * if an IEEE 754 double-precision number is converted to a decimal
+          string with at least 17 significant digits, and then converted back to
+          double-precision representation, the final result must match the
+          original number,
         * single precision floating point only guarntees 6 digits of precision,
           which is estimated to be too low for some use cases (e.g. storing
-          latitude/longitude with a resolution grater than 100m)
+          latitude/longitude with a resolution grater than 100m),
 * double precision floating point (IEEE 754) is a standard that ensures
-  compatibility with all database engines,
+  compatibility with majority of database engines,
     * the same data format is used internally by Ruby as a `Float`; it
       guarantees no conversions between storage and computation,
     * as a standard with hardware implementations ensures both: computing
       efficiency and hardware/3rd party library compatibility as opposed to Ruby
-      custom `BigDecimal` type
+      custom `BigDecimal` type,
+    * at present, only normalized numbers are used and considered sufficient, in
+      order to avoid potential issues with the cross-platform compatibility of
+      subnormal (denormal) numbers,
+* in the future, the IEEE 754 decimal64 data type may be considered once it is
+  supported by database engines.
+
+### Database layer vs application layer data model constraints
+
+* database constraints are the final guard against data integrity corruption,
+    * they should safeguard against data referential integrity loss under _all_
+      data (not schema) manipulation scenarios, including application level
+      logic errors and direct data manipulation (e.g. through `dbconsole`),
+* application constraints can be as restrictive as database constraints or more,
+  but not less, as it doesn't serve any use case,
+    * proper application level constraints should prevent unhandled database
+      exception occurences, e.g `ActiveRecord::InvalidForeignKey` for operations
+      performed through Models (i.e. not `#delete_all` etc.)
+
+### User interface
+* values provided by user have to be exactly preserved, avoiding any precision
+  loss due to e.g. type casting
+    * when it's not possible to store value without information loss, feedback has to
+      be given at the time of entering value
+    * values can be received using either:
+        * `input[number]` - validates: number format, value against `[min]` and
+          `[max]` attributes; cannot validate precision (no `[pattern]` support);
+          or
+        * `input[text]` - can validate number format and precision with
+          `[pattern]`; cannot validate range (no `[min]`/`[max]` support),
+        * none of the above prevents misinterpretation of values between 0 and
+          Float::MIN as 0.0 - this has to be checked manually,
+        * assuming that user input with _precision > DIG_ is as rare as in
+          the range _(0, MIN)_, the decision is to choose input which requires
+          the least/simplest additional code.

Gemfile

@@ -1,14 +1,18 @@
 source "https://rubygems.org"
 
 # The requirement for the Ruby version comes from Rails
-gem "rails", "~> 7.2.3"
+# NOTE: after updating Rails make sure that schema dump is not sorted:
+#   v8.1.3/activerecord/lib/active_record/schema_dumper.rb#L195
+# Waiting for this change to be reverted/configuration setting added:
+# https://github.com/rails/rails/pull/56842, https://github.com/rails/rails/pull/55414
+gem "rails", "~> 8.1.3"
 gem "sprockets-rails"
 gem "puma", "~> 6.0"
 gem "sassc-rails"
 # Windows does not include zoneinfo files, so bundle the tzinfo-data gem
 gem "tzinfo-data", platforms: %i[ mingw mswin x64_mingw jruby ]
 
-# TODO: select db gems automatically
+# TODO: select db gems automatically?
 #   database_config = ERB.new(File.read("config/database.yml")).result
 #   YAML.load(database_config, aliases: true).values.map { |env| env["adapter"] }.uniq
 group :mysql, optional: true do
@@ -42,11 +46,4 @@ group :test do
   # Use system testing [https://guides.rubyonrails.org/testing.html#system-testing]
   gem "capybara"
   gem "selenium-webdriver"
-
-  # Remove minitest version restriction after error fixed:
-  #   railties-7.2.3/lib/rails/test_unit/line_filtering.rb:7:in `run':
-  #     wrong number of arguments (given 3, expected 1..2) (ArgumentError)
-  #   from /var/www/.gem/ruby/3.3.0/gems/minitest-6.0.2/lib/minitest.rb:473:in
-  #     `block (2 levels) in run_suite'
-  gem "minitest", "< 6"
 end

Gemfile.lock

@@ -1,85 +1,85 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    actioncable (7.2.3)
-      actionpack (= 7.2.3)
-      activesupport (= 7.2.3)
+    action_text-trix (2.1.18)
+      railties
+    actioncable (8.1.3)
+      actionpack (= 8.1.3)
+      activesupport (= 8.1.3)
       nio4r (~> 2.0)
       websocket-driver (>= 0.6.1)
       zeitwerk (~> 2.6)
-    actionmailbox (7.2.3)
-      actionpack (= 7.2.3)
-      activejob (= 7.2.3)
-      activerecord (= 7.2.3)
-      activestorage (= 7.2.3)
-      activesupport (= 7.2.3)
+    actionmailbox (8.1.3)
+      actionpack (= 8.1.3)
+      activejob (= 8.1.3)
+      activerecord (= 8.1.3)
+      activestorage (= 8.1.3)
+      activesupport (= 8.1.3)
       mail (>= 2.8.0)
-    actionmailer (7.2.3)
-      actionpack (= 7.2.3)
-      actionview (= 7.2.3)
-      activejob (= 7.2.3)
-      activesupport (= 7.2.3)
+    actionmailer (8.1.3)
+      actionpack (= 8.1.3)
+      actionview (= 8.1.3)
+      activejob (= 8.1.3)
+      activesupport (= 8.1.3)
       mail (>= 2.8.0)
       rails-dom-testing (~> 2.2)
-    actionpack (7.2.3)
-      actionview (= 7.2.3)
-      activesupport (= 7.2.3)
-      cgi
+    actionpack (8.1.3)
+      actionview (= 8.1.3)
+      activesupport (= 8.1.3)
       nokogiri (>= 1.8.5)
-      racc
-      rack (>= 2.2.4, < 3.3)
+      rack (>= 2.2.4)
       rack-session (>= 1.0.1)
       rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.2)
       rails-html-sanitizer (~> 1.6)
       useragent (~> 0.16)
-    actiontext (7.2.3)
-      actionpack (= 7.2.3)
-      activerecord (= 7.2.3)
-      activestorage (= 7.2.3)
-      activesupport (= 7.2.3)
+    actiontext (8.1.3)
+      action_text-trix (~> 2.1.15)
+      actionpack (= 8.1.3)
+      activerecord (= 8.1.3)
+      activestorage (= 8.1.3)
+      activesupport (= 8.1.3)
       globalid (>= 0.6.0)
       nokogiri (>= 1.8.5)
-    actionview (7.2.3)
-      activesupport (= 7.2.3)
+    actionview (8.1.3)
+      activesupport (= 8.1.3)
       builder (~> 3.1)
-      cgi
       erubi (~> 1.11)
       rails-dom-testing (~> 2.2)
       rails-html-sanitizer (~> 1.6)
-    activejob (7.2.3)
-      activesupport (= 7.2.3)
+    activejob (8.1.3)
+      activesupport (= 8.1.3)
       globalid (>= 0.3.6)
-    activemodel (7.2.3)
-      activesupport (= 7.2.3)
-    activerecord (7.2.3)
-      activemodel (= 7.2.3)
-      activesupport (= 7.2.3)
+    activemodel (8.1.3)
+      activesupport (= 8.1.3)
+    activerecord (8.1.3)
+      activemodel (= 8.1.3)
+      activesupport (= 8.1.3)
       timeout (>= 0.4.0)
-    activestorage (7.2.3)
-      actionpack (= 7.2.3)
-      activejob (= 7.2.3)
-      activerecord (= 7.2.3)
-      activesupport (= 7.2.3)
+    activestorage (8.1.3)
+      actionpack (= 8.1.3)
+      activejob (= 8.1.3)
+      activerecord (= 8.1.3)
+      activesupport (= 8.1.3)
       marcel (~> 1.0)
-    activesupport (7.2.3)
+    activesupport (8.1.3)
       base64
-      benchmark (>= 0.3)
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.3.1)
       connection_pool (>= 2.2.5)
       drb
       i18n (>= 1.6, < 2)
+      json
       logger (>= 1.4.2)
       minitest (>= 5.1)
       securerandom (>= 0.3)
       tzinfo (~> 2.0, >= 2.0.5)
-    addressable (2.8.8)
+      uri (>= 0.13.1)
+    addressable (2.9.0)
       public_suffix (>= 2.0.2, < 8.0)
     base64 (0.3.0)
-    bcrypt (3.1.21)
-    benchmark (0.5.0)
-    bigdecimal (4.0.1)
+    bcrypt (3.1.22)
+    bigdecimal (4.1.2)
     bindex (0.8.1)
     builder (3.3.0)
     byebug (13.0.0)
@@ -93,28 +93,27 @@ GEM
       rack-test (>= 0.6.3)
       regexp_parser (>= 1.5, < 3.0)
       xpath (~> 3.2)
-    cgi (0.5.1)
     concurrent-ruby (1.3.6)
     connection_pool (3.0.2)
     crass (1.0.6)
     date (3.5.1)
-    devise (5.0.2)
+    devise (5.0.3)
       bcrypt (~> 3.0)
       orm_adapter (~> 0.1)
       railties (>= 7.0)
       responders
       warden (~> 1.2.3)
     drb (2.2.3)
-    erb (6.0.2)
+    erb (6.0.4)
     erubi (1.13.1)
-    ffi (1.17.3-aarch64-linux-gnu)
-    ffi (1.17.3-aarch64-linux-musl)
-    ffi (1.17.3-arm-linux-gnu)
-    ffi (1.17.3-arm-linux-musl)
-    ffi (1.17.3-arm64-darwin)
-    ffi (1.17.3-x86_64-darwin)
-    ffi (1.17.3-x86_64-linux-gnu)
-    ffi (1.17.3-x86_64-linux-musl)
+    ffi (1.17.4-aarch64-linux-gnu)
+    ffi (1.17.4-aarch64-linux-musl)
+    ffi (1.17.4-arm-linux-gnu)
+    ffi (1.17.4-arm-linux-musl)
+    ffi (1.17.4-arm64-darwin)
+    ffi (1.17.4-x86_64-darwin)
+    ffi (1.17.4-x86_64-linux-gnu)
+    ffi (1.17.4-x86_64-linux-musl)
     globalid (1.3.0)
       activesupport (>= 6.1)
     i18n (1.14.8)
@@ -124,13 +123,14 @@ GEM
       activesupport (>= 6.0.0)
       railties (>= 6.0.0)
     io-console (0.8.2)
-    irb (1.17.0)
+    irb (1.18.0)
       pp (>= 0.6.0)
       prism (>= 1.3.0)
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
+    json (2.19.4)
     logger (1.7.0)
-    loofah (2.25.0)
+    loofah (2.25.1)
       crass (~> 1.0.2)
       nokogiri (>= 1.12.0)
     mail (2.9.0)
@@ -142,10 +142,12 @@ GEM
     marcel (1.1.0)
     matrix (0.4.3)
     mini_mime (1.1.5)
-    minitest (5.27.0)
+    minitest (6.0.6)
+      drb (~> 2.0)
+      prism (~> 1.5)
     mysql2 (0.5.7)
       bigdecimal
-    net-imap (0.6.3)
+    net-imap (0.6.4)
       date
       net-protocol
     net-pop (0.1.2)
@@ -155,21 +157,21 @@ GEM
     net-smtp (0.5.1)
       net-protocol
     nio4r (2.7.5)
-    nokogiri (1.19.1-aarch64-linux-gnu)
+    nokogiri (1.19.3-aarch64-linux-gnu)
       racc (~> 1.4)
-    nokogiri (1.19.1-aarch64-linux-musl)
+    nokogiri (1.19.3-aarch64-linux-musl)
       racc (~> 1.4)
-    nokogiri (1.19.1-arm-linux-gnu)
+    nokogiri (1.19.3-arm-linux-gnu)
       racc (~> 1.4)
-    nokogiri (1.19.1-arm-linux-musl)
+    nokogiri (1.19.3-arm-linux-musl)
       racc (~> 1.4)
-    nokogiri (1.19.1-arm64-darwin)
+    nokogiri (1.19.3-arm64-darwin)
       racc (~> 1.4)
-    nokogiri (1.19.1-x86_64-darwin)
+    nokogiri (1.19.3-x86_64-darwin)
       racc (~> 1.4)
-    nokogiri (1.19.1-x86_64-linux-gnu)
+    nokogiri (1.19.3-x86_64-linux-gnu)
       racc (~> 1.4)
-    nokogiri (1.19.1-x86_64-linux-musl)
+    nokogiri (1.19.3-x86_64-linux-musl)
       racc (~> 1.4)
     orm_adapter (0.5.0)
     pg (1.6.3)
@@ -186,32 +188,32 @@ GEM
     psych (5.3.1)
       date
       stringio
-    public_suffix (7.0.2)
+    public_suffix (7.0.5)
     puma (6.6.1)
       nio4r (~> 2.0)
     racc (1.8.1)
-    rack (3.2.5)
-    rack-session (2.1.1)
+    rack (3.2.6)
+    rack-session (2.1.2)
       base64 (>= 0.1.0)
       rack (>= 3.0.0)
     rack-test (2.2.0)
       rack (>= 1.3)
     rackup (2.3.1)
       rack (>= 3)
-    rails (7.2.3)
-      actioncable (= 7.2.3)
-      actionmailbox (= 7.2.3)
-      actionmailer (= 7.2.3)
-      actionpack (= 7.2.3)
-      actiontext (= 7.2.3)
-      actionview (= 7.2.3)
-      activejob (= 7.2.3)
-      activemodel (= 7.2.3)
-      activerecord (= 7.2.3)
-      activestorage (= 7.2.3)
-      activesupport (= 7.2.3)
+    rails (8.1.3)
+      actioncable (= 8.1.3)
+      actionmailbox (= 8.1.3)
+      actionmailer (= 8.1.3)
+      actionpack (= 8.1.3)
+      actiontext (= 8.1.3)
+      actionview (= 8.1.3)
+      activejob (= 8.1.3)
+      activemodel (= 8.1.3)
+      activerecord (= 8.1.3)
+      activestorage (= 8.1.3)
+      activesupport (= 8.1.3)
       bundler (>= 1.15.0)
-      railties (= 7.2.3)
+      railties (= 8.1.3)
     rails-dom-testing (2.3.0)
       activesupport (>= 5.0.0)
       minitest
@@ -219,29 +221,28 @@ GEM
     rails-html-sanitizer (1.7.0)
       loofah (~> 2.25)
       nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0)
-    railties (7.2.3)
-      actionpack (= 7.2.3)
-      activesupport (= 7.2.3)
-      cgi
+    railties (8.1.3)
+      actionpack (= 8.1.3)
+      activesupport (= 8.1.3)
       irb (~> 1.13)
       rackup (>= 1.0.0)
       rake (>= 12.2)
       thor (~> 1.0, >= 1.2.2)
       tsort (>= 0.2)
       zeitwerk (~> 2.6)
-    rake (13.3.1)
+    rake (13.4.2)
     rdoc (7.2.0)
       erb
       psych (>= 4.0.0)
       tsort
-    regexp_parser (2.11.3)
+    regexp_parser (2.12.0)
     reline (0.6.3)
       io-console (~> 0.5)
     responders (3.2.0)
       actionpack (>= 7.0)
       railties (>= 7.0)
     rexml (3.4.4)
-    rubyzip (3.2.2)
+    rubyzip (3.3.0)
     sassc (2.4.0)
       ffi (~> 1.9)
     sassc-rails (2.1.2)
@@ -251,7 +252,7 @@ GEM
       sprockets-rails
       tilt
     securerandom (0.4.1)
-    selenium-webdriver (4.41.0)
+    selenium-webdriver (4.43.0)
       base64 (~> 0.2)
       logger (~> 1.4)
       rexml (~> 3.2, >= 3.2.5)
@@ -265,32 +266,32 @@ GEM
       actionpack (>= 6.1)
       activesupport (>= 6.1)
       sprockets (>= 3.0.0)
-    sqlite3 (2.9.0-aarch64-linux-gnu)
-    sqlite3 (2.9.0-aarch64-linux-musl)
-    sqlite3 (2.9.0-arm-linux-gnu)
-    sqlite3 (2.9.0-arm-linux-musl)
-    sqlite3 (2.9.0-arm64-darwin)
-    sqlite3 (2.9.0-x86_64-darwin)
-    sqlite3 (2.9.0-x86_64-linux-gnu)
-    sqlite3 (2.9.0-x86_64-linux-musl)
+    sqlite3 (2.9.3-aarch64-linux-gnu)
+    sqlite3 (2.9.3-aarch64-linux-musl)
+    sqlite3 (2.9.3-arm-linux-gnu)
+    sqlite3 (2.9.3-arm-linux-musl)
+    sqlite3 (2.9.3-arm64-darwin)
+    sqlite3 (2.9.3-x86_64-darwin)
+    sqlite3 (2.9.3-x86_64-linux-gnu)
+    sqlite3 (2.9.3-x86_64-linux-musl)
     stringio (3.2.0)
     thor (1.5.0)
     tilt (2.7.0)
-    timeout (0.6.0)
+    timeout (0.6.1)
     tsort (0.2.0)
     turbo-rails (2.0.23)
       actionpack (>= 7.1.0)
       railties (>= 7.1.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
+    uri (1.1.1)
     useragent (0.16.11)
     warden (1.2.9)
       rack (>= 2.0.9)
-    web-console (4.2.1)
-      actionview (>= 6.0.0)
-      activemodel (>= 6.0.0)
+    web-console (4.3.0)
+      actionview (>= 8.0.0)
       bindex (>= 0.4.0)
-      railties (>= 6.0.0)
+      railties (>= 8.0.0)
     websocket (1.2.11)
     websocket-driver (0.8.0)
       base64
@@ -315,11 +316,10 @@ DEPENDENCIES
   capybara
   devise
   importmap-rails
-  minitest (< 6)
   mysql2 (~> 0.5)
   pg (~> 1.5)
   puma (~> 6.0)
-  rails (~> 7.2.3)
+  rails (~> 8.1.3)
   sassc-rails
   selenium-webdriver
   sprockets-rails

README.md

@@ -16,14 +16,10 @@ environment, see the _Contributing_ section below.
 * Server side:
     * Ruby interpreter, depending on the version of Rails used (see _Gemfile_),
         * https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#ruby-versions
-    * database (e.g. MySQL >= 8.0) supporting:
+    * database (e.g. SQLite, MySQL >= 8.0) supporting:
         * recursive Common Table Expressions (CTE) for SELECT/UPDATE/DELETE,
             * MariaDB does not support CTE for UPDATE/DELETE
               (https://jira.mariadb.org/browse/MDEV-18511)
-        * decimal datatype with precision of at least 30,
-            * SQLite3 _flexible typing_ decimal will work, but precision
-              will be limited to 16, making it practical mostly for testing
-              purposes
     * for testing: browser as specified in _Client side_ requirements
 * Client side:
     * browser (e.g. Firefox >= 121) supporting:
@@ -89,14 +85,10 @@ Running
 
 ### Standalone Rails server + Apache proxy
 
-Customize Puma config template:
+Copy and customize Puma config template if required:
 
     cp -a config/puma.rb.dist config/puma.rb
 
-and specify server IP/port, either with `port` or `bind`, e.g.:
-
-    bind 'tcp://0.0.0.0:3000'
-
 #### (option 1) Start server manually
 
     bundle exec rails s -e production
@@ -123,9 +115,10 @@ Contributing
 
 ### Gems
 
-Apart from database adapter, install development and testing gems:
+Install development and testing gems, including at least MySQL and SQLite
+database adapters:
 
-    bundle config --local with mysql development test
+    bundle config --local with development test mysql sqlite
 
 ### Configuration
 
@@ -138,20 +131,29 @@ assets.
 
 ### Database
 
-Grant database user privileges for development and test environments,
-possibly with different Ruby versions:
+Grant database user privileges for development and test environments. Example
+below shows how to grant privileges to all databases which names start with
+`fixinme-` on MySQL:
 
     > mysql -p
     mysql> create user `fixinme-dev`@localhost identified by '<some password>';
     mysql> grant all privileges on `fixinme-%`.* to `fixinme-dev`@localhost;
     mysql> flush privileges;
 
+Dumping development data before database reset:
+
+    mysqldump -h <address> -u <user> -p --no-create-info --no-tablespaces --complete-insert <database> > tmp/data.sql
+
 ### Development environment
 
 Starting application server in development environment:
 
     bundle exec rails s -e development
 
+Accessing database console when more than one test db is present:
+
+    bundle exec rails dbconsole -e test --db sqlite3
+
 For running rake tasks, prepend command with environment:
 
     RAILS_ENV=development bundle exec rails ...
@@ -164,14 +166,22 @@ Tests need to be run from within toplevel application directory:
 
         bundle exec rails test:system
 
-* system test(s) with seed/test name specified:
+* system test(s) with seed or test name specified:
 
-        bundle exec rails test:system --seed 64690 --name test_add_unit
+        bundle exec rails test:system --include test_add_unit --seed 64690
 
-* all tests from one file, with optional seed:
+* all tests from one file, optionally with seed:
 
         bundle exec rails test test/system/users_test.rb --seed 1234
 
+* system tests for selected database configuration (if multiple present):
+
+        bundle exec rails test:system --include /^test_sqlite3_/
+
+* single system test for all database configurations (if multiple present):
+
+        bundle exec rails test:system --include /^test_\\w+_add_unit$/
+
 ### Icons
 
 Pictogrammers Material Design Icons: https://pictogrammers.com/library/mdi/

app/assets/images/pictograms/view-columns.svg

@@ -1 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" id="icon" viewBox="0 0 24 24"><path d="M4,4H8V20H4V4M10,4H14V20H10V4M16,4H21V20H16V4Z"/></svg>

app/assets/images/pictograms/view-rows.svg

@@ -1 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" id="icon" viewBox="0 0 24 24"><path d="M3,5H21V7H3V5M3,11H21V13H3V11M3,17H21V19H3V17Z"/></svg>

app/assets/stylesheets/application.css

@@ -36,7 +36,6 @@
   --color-blue: #009ade;
   --color-dark-red: #b21237;
   --color-red: #ff1f5b;
-  --color-purple: #8b2be2;
 
   --depth: 0;
 
@@ -58,6 +57,11 @@
 }
 /* NOTE: move to higher priority layer instead of using !important?; add CSS
  * @layer requirements in README */
+/* Disable elements with:
+ *  `[aria-disabled=true]` - non-form elements (e.g. links),
+ *  `[disabled]` - form controls, that may be enabled conditionally,
+ *  `[readonly]` - form controls, that stay disabled for form lifetime. */
+[aria-disabled=true],
 [disabled] {
   border-color: var(--color-border-gray) !important;
   color: var(--color-border-gray) !important;
@@ -111,11 +115,6 @@ svg {
 svg:last-child {
   margin-right: 0;
 }
-.chart-panel svg {
-  height: auto;
-  margin: 0;
-  width: auto;
-}
 textarea {
   margin: 0;
 }
@@ -205,6 +204,10 @@ textarea:invalid {
   border-color: var(--color-red);
   outline-color: var(--color-red);
 }
+pre {
+  display: inline;
+  font: inherit;
+}
 
 /* `.button`: button-styled <a>, <button>, <input type=submit>.
  * `.link`: any other <a>.
@@ -237,16 +240,17 @@ textarea:invalid {
   text-decoration: underline 1px var(--color-border-gray);
   text-underline-offset: 0.25em;
 }
-button.link {
-  border: none;
-  padding: 0;
-}
-[name=cancel],
 .auxiliary {
-  border-color: var(--color-border-gray);
+  border-color: var(--color-nav-gray);
   color: var(--color-nav-gray);
   fill: var(--color-nav-gray);
 }
+table .button {
+  border-color: var(--color-border-gray);
+  font-weight: normal;
+  height: 100%;
+  padding: 0.4em;
+}
 .button:focus-visible,
 .tab:focus-visible,
 .tab:hover {
@@ -262,13 +266,6 @@ button.link {
   background-color: var(--color-red);
   border-color: var(--color-red);
 }
-tr:has(select[data-changed]) button[name="button"],
-.set-default-unit:not([disabled]) {
-  background-color: var(--color-purple);
-  border-color: var(--color-purple);
-  color: white;
-  fill: white;
-}
 .link:focus-visible {
   text-decoration-color: var(--color-gray);
 }
@@ -276,13 +273,6 @@ tr:has(select[data-changed]) button[name="button"],
   color: var(--color-blue);
   text-decoration-color: var(--color-blue);
 }
-table .button {
-  border-color: var(--color-border-gray);
-  color: var(--color-table-gray);
-  font-weight: normal;
-  height: 100%;
-  padding: 0.4em;
-}
 
 
 /* NOTE: collapse gaps around empty rows (`topside`) once possible with
@@ -377,21 +367,21 @@ header {
   line-height: 2.2em;
   pointer-events: auto;
 }
-.flash:before {
-  filter: invert(100%);
+.flash::before {
+  filter: invert(1);
   height: 1.4em;
   margin: 0 0.5em;
   width: 1.4em;
 }
-.flash.alert:before {
-  content: url('pictograms/alert-outline.svg');
+.flash.alert::before {
+  content: url('alert-outline.svg');
 }
 .flash.alert {
   border-color: var(--color-red);
   background-color: var(--color-red);
 }
-.flash.notice:before {
-  content: url('pictograms/check-circle-outline.svg');
+.flash.notice::before {
+  content: url('check-circle-outline.svg');
 }
 .flash.notice {
   border-color: var(--color-blue);
@@ -454,15 +444,18 @@ header {
 
 .tabular-form table {
   border: none;
-  border-spacing: 0.4em 0;
-  margin-inline: -0.4em;
+  border-spacing: 0;
 }
 .tabular-form table td {
   border: none;
+  padding-inline-start: 0.4em;
   vertical-align: middle;
 }
-.tabular-form table td {
-  padding-inline: 0;
+.tabular-form table td:first-child {
+  padding-inline-start: 0;
+}
+.tabular-form table td:last-child {
+  padding-inline-end: 0;
 }
 .tabular-form table :is(form, input, select, textarea):only-child {
   margin-inline-start: 0;
@@ -530,7 +523,7 @@ header {
   cursor: grab;
 }
 .items-table .form td {
-  vertical-align: middle;
+  vertical-align: top;
 }
 .items-table td:not(:first-child),
 .grayed {
@@ -595,7 +588,7 @@ summary::before {
   background-color: currentColor;
   content: "";
   height: 1em;
-  mask-image: url('pictograms/chevron-down.svg');
+  mask-image: url('chevron-down.svg');
   mask-size: cover;
   width: 1em;
 }
@@ -657,45 +650,3 @@ li::marker {
   min-width: 66%;
   width: max-content;
 }
-.measurements-section {
-  overflow-x: auto;
-}
-body[data-measurements-view=wide] .measurements-compact,
-body[data-measurements-view=compact] .measurements-wide {
-  display: none;
-}
-body[data-measurements-view=compact] .view-toggle[data-view=compact],
-body[data-measurements-view=wide] .view-toggle[data-view=wide] {
-  background-color: var(--color-blue);
-  border-color: var(--color-blue);
-  color: white;
-  fill: white;
-}
-.chart-panel {
-  width: 100%;
-}
-#measurements tr.grouped td {
-  border-top: none;
-}
-#measurements tr.grouped .taken-at,
-#measurements tr.grouped .created-at {
-  visibility: hidden;
-}
-.measurements-wide td {
-  vertical-align: middle;
-  white-space: nowrap;
-}
-.wide-cell {
-  align-items: center;
-  display: inline-flex;
-  gap: 0.25em;
-}
-.wide-cell .button {
-  border: none;
-  font-size: inherit;
-  height: auto;
-  padding: 0;
-}
-.wide-cell button.link::after {
-  content: none;
-}

app/controllers/charts_controller.rb

@@ -1,12 +0,0 @@
-class ChartsController < ApplicationController
-  def index
-    readouts = current_user.readouts.includes(:quantity, :unit).order(:taken_at, :id)
-    @readouts_json = readouts.map { |r|
-      { takenAt: r.taken_at&.iso8601,
-        quantityId: r.quantity_id,
-        quantityName: r.quantity.name,
-        value: r.value.to_f,
-        unit: r.unit.symbol }
-    }.to_json
-  end
-end

app/controllers/measurements_controller.rb

@@ -1,12 +1,7 @@
 class MeasurementsController < ApplicationController
-  before_action :find_readout, only: [:destroy, :edit, :update]
-
-  before_action except: :index do
-    raise AccessForbidden unless current_user.at_least(:active)
-  end
-
   def index
-    load_measurements
+    @measurements = []
+    #@measurements = current_user.units.ordered.includes(:base, :subunits)
   end
 
   def new
@@ -14,49 +9,8 @@ class MeasurementsController < ApplicationController
   end
 
   def create
-    taken_at = params.permit(:taken_at)[:taken_at]
-    readout_params = params.permit(readouts: Readout::ATTRIBUTES).fetch(:readouts, [])
-    @readouts = readout_params.map { |rp| current_user.readouts.build(rp.merge(taken_at: taken_at)) }
-
-    if @readouts.present? && @readouts.all?(&:valid?)
-      ActiveRecord::Base.transaction { @readouts.each(&:save!) }
-      load_measurements
-      flash.now[:notice] = t('.success', count: @readouts.size)
-    else
-      errors = @readouts.flat_map { |r| r.errors.full_messages }
-      flash.now[:alert] = errors.present? ? errors.first : t('.no_readouts')
-    end
-  end
-
-  def edit
-    @user_units = current_user.units.ordered
-  end
-
-  def update
-    if @readout.update(params.require(:readout).permit(:value, :unit_id, :taken_at))
-      load_measurements
-      flash.now[:notice] = t('.success')
-    else
-      @user_units = current_user.units.ordered
-      render :edit
-    end
   end
 
   def destroy
-    @readout.destroy!
-    load_measurements
-    flash.now[:notice] = t('.success')
-  end
-
-  private
-
-  def find_readout
-    @readout = current_user.readouts.find(params[:id])
-  end
-
-  def load_measurements
-    @measurements = current_user.readouts.includes(:quantity, :unit).order(taken_at: :desc, id: :desc)
-    @wide_groups = @measurements.group_by(&:taken_at)
-    @wide_quantities = @measurements.map(&:quantity).uniq.sort_by(&:name)
   end
 end

app/controllers/quantities_controller.rb

@@ -8,10 +8,6 @@ class QuantitiesController < ApplicationController
     raise AccessForbidden unless current_user.at_least(:active)
   end
 
-  before_action only: [:new, :edit, :create, :update] do
-    @user_units = current_user.units.ordered
-  end
-
   def index
     @quantities = current_user.quantities.ordered.includes(:parent, :subquantities)
   end

app/controllers/readouts_controller.rb

@@ -6,7 +6,7 @@ class ReadoutsController < ApplicationController
   def new
     @quantities -= @prev_quantities
     # TODO: raise ParameterInvalid if new_quantities.empty?
-    @readouts = current_user.readouts.build(@quantities.map { |q| {quantity: q} })
+    @readouts = @quantities.map { |q| q.readouts.build }
 
     @user_units = current_user.units.ordered
 

app/controllers/units_controller.rb

@@ -17,7 +17,7 @@ class UnitsController < ApplicationController
   end
 
   def create
-    @unit = current_user.units.new(unit_params)
+    @unit = current_user.units.new(params.expect(Unit::ATTRIBUTES))
     if @unit.save
       @before = @unit.successive
       flash.now[:notice] = t('.success', unit: @unit)
@@ -30,7 +30,7 @@ class UnitsController < ApplicationController
   end
 
   def update
-    if @unit.update(unit_params.except(:base_id))
+    if @unit.update(params.except(:base_id).expect(Unit::ATTRIBUTES))
       flash.now[:notice] = t('.success', unit: @unit)
     else
       render :edit
@@ -40,11 +40,11 @@ class UnitsController < ApplicationController
   # TODO: Avoid double table width change by first un-hiding table header,
   # then displaying index, e.g. by re-displaying header in index
   def rebase
-    permitted = params.require(:unit).permit(:base_id)
-    permitted.merge!(multiplier: 1) if permitted[:base_id].blank? && @unit.multiplier != 1
+    unit_params = params.expect(unit: :base_id)
+    unit_params.merge!(multiplier: 1.0) if unit_params[:base_id].blank?
 
     @previous_base = @unit.base
-    @unit.update!(permitted)
+    @unit.update!(unit_params)
 
     @before = @unit.successive
     if @unit.multiplier_previously_changed?
@@ -59,10 +59,6 @@ class UnitsController < ApplicationController
 
   private
 
-  def unit_params
-    params.require(:unit).permit(Unit::ATTRIBUTES)
-  end
-
   def find_unit
     @unit = current_user.units.find_by!(id: params[:id])
   end

app/helpers/application_helper.rb

@@ -86,7 +86,6 @@ module ApplicationHelper
     def initialize(...)
       super(...)
       @default_options.merge!(@options.slice(:form))
-      @default_html_options.merge!(@options.slice(:form))
     end
 
     [:text_field, :password_field, :text_area].each do |selector|
@@ -102,18 +101,14 @@ module ApplicationHelper
     end
 
     def number_field(method, options = {})
-      attr_type = object.type_for_attribute(method)
-      case attr_type.type
-      when :decimal
-        options[:value] = object.public_send(method)&.to_scientific
-        options[:step] ||= BigDecimal(10).power(-attr_type.scale)
-        options[:max] ||= BigDecimal(10).power(attr_type.precision - attr_type.scale) -
-          options[:step]
-        options[:min] = options[:min] == :step ? options[:step] : options[:min]
-        options[:min] ||= -options[:max]
-        options[:size] ||= attr_type.precision / 2
-      when :float
+      case object.type_for_attribute(method).type
+      when :float, :double
+        options[:min] ||= Float::MIN_15.to_scientific
+        options[:max] ||= Float::MAX_15.to_scientific
+        options[:oninput] = 'numberValidate(event)'
         options[:size] ||= 6
+        options[:step] ||= :any
+        options[:value] = object.public_send("#{method}_before_type_cast")
       end
       super
     end
@@ -132,7 +127,7 @@ module ApplicationHelper
 
     def submit_default_value
       svg_name = object ? (object.persisted? ? 'update' : 'plus-circle-outline') : ''
-      @template.svg_tag("pictograms/#{svg_name}", super)
+      @template.svg_tag(svg_name, super)
     end
 
     def except_pattern(value, pattern = nil)
@@ -161,7 +156,7 @@ module ApplicationHelper
   def svg_tag(source, label = nil, options = {})
     label, options = nil, label if label.is_a? Hash
     svg_tag = tag.svg(**options) do
-      tag.use(href: "#{image_path(source + ".svg")}#icon")
+      tag.use(href: image_path("#{source}.svg") + '#icon')
     end
     label.blank? ? svg_tag : svg_tag + tag.span(label)
   end
@@ -171,14 +166,13 @@ module ApplicationHelper
       ['measurements', 'scale-bathroom', :restricted],
       ['quantities', 'axis-arrow', :restricted, 'right'],
       ['units', 'weight-gram', :restricted],
-      ['charts', 'chart-line', :restricted],
       # TODO: display users tab only if >1 user present; sole_user?/sole_admin?
       ['users', 'account-multiple-outline', :admin],
     ]
 
     menu_tabs.map do |name, image, status, css_class|
       if current_user.at_least(status)
-        link_to svg_tag("pictograms/#{image}", t("#{name}.navigation")),
+        link_to svg_tag(image, t("#{name}.navigation")),
           {controller: "/#{name}", action: "index"},
           class: class_names('tab', css_class, active: name == current_tab)
       end
@@ -210,9 +204,7 @@ module ApplicationHelper
 
   def image_link_to_unless_current(name, image = nil, options = nil, html_options = {})
     name, html_options = link_or_button_options(:link, name, image, html_options)
-    # NOTE: Starting from Rails 8.1.0, below condition can be replaced with:
-    #   current_page?(options, method: [:get, :post])
-    if request.path == url_for(options)
+    if current_page?(options, method: [:get, :post])
       html_options = html_options.deep_merge DISABLED_ATTRIBUTES
     end
     link_to name, options, html_options
@@ -231,7 +223,7 @@ module ApplicationHelper
       Array(messages).map do |message|
         tag.div class: "flash #{entry}" do
           tag.span(sanitize(message)) +
-            svg_tag('pictograms/close-outline', {onclick: "this.parentElement.remove()"})
+            svg_tag('close-outline', {onclick: "this.parentElement.remove()"})
         end
       end
     end.join.html_safe
@@ -263,7 +255,7 @@ module ApplicationHelper
     link_is_local = html_options[:onclick] || html_options.dig(:data, :turbo_stream)
     name = name.to_s
     name += '...' if type == :link && !link_is_local
-    name = svg_tag("pictograms/#{image}", name) if image
+    name = svg_tag(image, name) if image
 
     [name, html_options]
   end

app/javascript/application.js

@@ -3,105 +3,14 @@
 import "@hotwired/turbo-rails"
 
 
-/* Hide page before loaded for testing purposes */
+// Show page if hidden for testing purposes.
 function showPage(event) {
   document.documentElement.style.visibility="visible"
 }
 document.addEventListener('turbo:load', showPage)
 
-function groupMeasurements() {
-  var tbody = document.getElementById('measurements');
-  if (!tbody) return;
-  var prevTakenAt = null;
-  Array.from(tbody.querySelectorAll('tr[data-taken-at]'))
-    .filter(function(row) { return row.style.display !== 'none' })
-    .forEach(function(row) {
-      var takenAt = row.dataset.takenAt;
-      row.classList.toggle('grouped', takenAt !== null && takenAt === prevTakenAt);
-      prevTakenAt = takenAt;
-    });
-}
-
-
-function buildCharts() {
-  var container = document.getElementById('measurements-charts');
-  var dataEl = document.getElementById('charts-data');
-  if (!container || !dataEl) return;
-
-  var readouts = JSON.parse(dataEl.textContent);
-  container.innerHTML = '';
-  if (readouts.length === 0) return;
-
-  // Data arrives sorted by taken_at from the server; group into per-quantity traces
-  var quantities = new Map();
-  readouts.forEach(function(r) {
-    if (!r.takenAt) return;
-    if (!quantities.has(r.quantityId)) {
-      quantities.set(r.quantityId, { name: r.quantityName, unit: r.unit, x: [], y: [] });
-    }
-    var q = quantities.get(r.quantityId);
-    q.x.push(r.takenAt);
-    q.y.push(r.value);
-  });
-
-  var traces = [];
-  quantities.forEach(function(q) {
-    traces.push({
-      x: q.x,
-      y: q.y,
-      mode: 'lines+markers',
-      type: 'scatter',
-      name: q.name + ' (' + q.unit + ')',
-      marker: { size: 5 }
-    });
-  });
-
-  var div = document.createElement('div');
-  div.className = 'chart-panel';
-  container.appendChild(div);
-
-  Plotly.newPlot(div, traces, {
-    xaxis: { type: 'date', tickformat: '%Y-%m-%d %H:%M' },
-    yaxis: {},
-    margin: { t: 20, r: 20, b: 80, l: 60 },
-    paper_bgcolor: 'transparent',
-    plot_bgcolor: 'transparent',
-    font: { family: 'system-ui' },
-    legend: { orientation: 'h', y: -0.25 }
-  }, { responsive: true, displayModeBar: false });
-}
-
-function getMeasurementsView() {
-  return localStorage.getItem('measurements-view') || 'compact';
-}
-
-function applyMeasurementsView(view) {
-  document.body.dataset.measurementsView = view;
-}
-
-function setMeasurementsView(view) {
-  localStorage.setItem('measurements-view', view);
-  applyMeasurementsView(view);
-}
-window.setMeasurementsView = setMeasurementsView
-
-document.addEventListener('turbo:load', function() {
-  if (document.getElementById('charts-data')) {
-    buildCharts();
-    return;
-  }
-  var tbody = document.getElementById('measurements');
-  if (!tbody) return;
-  groupMeasurements();
-  applyMeasurementsView(getMeasurementsView());
-  new MutationObserver(function() {
-    groupMeasurements();
-  }).observe(tbody, {
-    childList: true, subtree: true,
-    attributes: true, attributeFilter: ['style']
-  });
-})
 
+// <details> event handlers.
 function detailsChange(event) {
   var target = event.currentTarget
   var count = target.querySelectorAll('input:checked:not([disabled])').length
@@ -117,7 +26,7 @@ function detailsChange(event) {
 }
 window.detailsChange = detailsChange
 
-/* Close open <details> when focus lost */
+// Close open <details> when focus lost.
 function detailsClose(event) {
   if (!event.relatedTarget ||
       event.relatedTarget.closest("details") != event.currentTarget) {
@@ -131,44 +40,7 @@ window.detailsObserver = new MutationObserver((mutations) => {
 });
 
 
-function readoutUnitChanged(select) {
-  var button = select.closest('tr').querySelector('.set-default-unit');
-  if (select.value && select.value !== select.dataset.defaultUnitId) {
-    button.removeAttribute('disabled');
-    button.removeAttribute('aria-disabled');
-    button.removeAttribute('tabindex');
-  } else {
-    button.setAttribute('disabled', 'disabled');
-    button.setAttribute('aria-disabled', 'true');
-    button.setAttribute('tabindex', '-1');
-  }
-}
-window.readoutUnitChanged = readoutUnitChanged
-
-function setDefaultUnit(button) {
-  var select = button.closest('tr').querySelector('select[data-default-unit-id]');
-  var form = document.createElement('form');
-  form.action = button.dataset.path;
-  form.method = 'post';
-  form.dataset.turboStream = 'true';
-  var methodInput = document.createElement('input');
-  methodInput.type = 'hidden'; methodInput.name = '_method'; methodInput.value = 'patch';
-  var unitInput = document.createElement('input');
-  unitInput.type = 'hidden'; unitInput.name = 'quantity[default_unit_id]'; unitInput.value = select.value;
-  form.appendChild(methodInput);
-  form.appendChild(unitInput);
-  form.addEventListener('turbo:submit-end', function(event) {
-    if (event.detail.success) {
-      select.dataset.defaultUnitId = select.value;
-      readoutUnitChanged(select);
-    }
-    form.remove();
-  });
-  document.body.appendChild(form);
-  form.requestSubmit();
-}
-window.setDefaultUnit = setDefaultUnit
-
+// Validation of multiple-submit forms with different field requirements.
 function formValidate(event) {
   var id = event.submitter.getAttribute("data-validate")
   if (!id) return;
@@ -181,28 +53,58 @@ function formValidate(event) {
 }
 window.formValidate = formValidate
 
+// Pattern for number precision verification. Should accept all number formats
+// accepted by Kernel#Float. Lookahead checks the number of significant digits
+// in mantissa, following expression makes sure there is only one dot.
+const numberRegExp = /^\-?(?=(?:\.?0)*(?:\.?\d){1,15}?(?:\.?0)*\.?(?:[eE]|$))(?<mantissa>\d*\.?\d+|\d+\.)(?:[eE]\-?\d{1,3})?$/
 
-/* Turbo stream actions */
+// Validation of input[type=number] value precision.
+function numberValidate(event) {
+  var input = event.target
+
+  input.setCustomValidity("")
+  if (!input.validity.valid) return
+
+  var match = numberRegExp.exec(input.value)
+  if (!match ||
+      (parseFloat(input.value) == 0.0 && match.groups['mantissa'].match(/[1-9]/))) {
+    // TODO: move message to locales
+    input.setCustomValidity("Please select a value within range of double precision floating-point format.")
+  }
+}
+window.numberValidate = numberValidate
+
+
+// Turbo stream actions.
+const FORM_CONTROLS = ["BUTTON", "FIELDSET", "INPUT", "OPTGROUP", "OPTION", "SELECT",
+                       "TEXTAREA"]
 Turbo.StreamElement.prototype.disableElement = function(element) {
+  if (FORM_CONTROLS.includes(element.tagName)) {
     element.setAttribute("disabled", "disabled")
+  } else {
     element.setAttribute("aria-disabled", "true")
+    // NOTE: tabindex should not be disabled?
     element.setAttribute("tabindex", "-1")
+  }
 }
 Turbo.StreamActions.disable = function() {
   this.targetElements.forEach((e) => { this.disableElement(e) })
 }
 
 Turbo.StreamElement.prototype.enableElement = function(element) {
+  if (FORM_CONTROLS.includes(element.tagName)) {
     element.removeAttribute("disabled")
+  } else {
     element.removeAttribute("aria-disabled")
-    // Assume 'tabindex' is not used explicitly, so removing it is safe
+    // Assume 'tabindex' is not used explicitly, so removing it is safe.
     element.removeAttribute("tabindex")
+  }
 }
 Turbo.StreamActions.enable = function() {
   this.targetElements.forEach((e) => { this.enableElement(e) })
 }
 
-/* TODO: change to visibility = collapse to avoid width change? */
+// TODO: change to visibility = collapse to avoid width change?
 Turbo.StreamActions.hide = function() {
   this.targetElements.forEach((e) => { e.style.display = "none" })
 }
@@ -219,7 +121,7 @@ Turbo.StreamActions.collapse = function() {
 
 Turbo.StreamActions.close_form = function() {
   this.targetElements.forEach((e) => {
-    /* Move focus if there's no focus or focus inside form being closed */
+    // Move focus if there's no focus or focus inside form being closed.
     const focused = document.activeElement
     if (!focused || (focused == document.body) || e.contains(focused)) {
       let nextForm = e.parentElement.querySelector(`#${e.id} ~ tr:has([autofocus])`)
@@ -244,6 +146,8 @@ Turbo.StreamActions.unselect = function() {
   })
 }
 
+
+// Keyboard event processing handlers.
 function formProcessKey(event) {
   switch (event.key) {
     case "Escape":
@@ -270,7 +174,7 @@ function detailsProcessKey(event) {
       var button = event.currentTarget.querySelector("button:not([disabled])")
       if (button) {
         button.click()
-        // Autofocus won't be respected unless target is blurred
+        // Autofocus won't be respected unless target is blurred.
         event.target.blur()
         event.preventDefault()
         event.stopPropagation()
@@ -280,7 +184,8 @@ function detailsProcessKey(event) {
 }
 window.detailsProcessKey = detailsProcessKey;
 
-/* Items table drag and drop support */
+
+// Items table drag and drop support.
 var lastEnterTime
 function dragStart(event) {
   lastEnterTime = event.timeStamp
@@ -290,7 +195,8 @@ function dragStart(event) {
   })
   event.dataTransfer.setData("text/plain", row.getAttribute("data-drag-path"))
   var rowRectangle = row.getBoundingClientRect()
-  event.dataTransfer.setDragImage(row, event.x - rowRectangle.left, event.y - rowRectangle.top)
+  event.dataTransfer.setDragImage(row, event.x - rowRectangle.left,
+                                  event.y - rowRectangle.top)
   event.dataTransfer.dropEffect = "move"
 }
 window.dragStart = dragStart
@@ -300,7 +206,7 @@ window.dragStart = dragStart
 *   * Enter/Leave events at the same timeStamp may not be logically ordered
 *     (e.g. E -> E -> L, not E -> L -> E),
 *   * not every Enter event has corresponding Leave event, especially during
-*     rapid pointer moves
+*     rapid pointer moves.
 * NOTE: sometimes Leave is not emitted when pointer goes fast over table
 * and outside. This should probably be fixed in browser, than patched here.
 */
@@ -320,7 +226,7 @@ window.dragOver = dragOver
 
 function dragLeave(event) {
   //console.log(event.timeStamp + " " + event.type + ": " + event.currentTarget.id)
-  // Leave has been accounted for by Enter at the same timestamp, processed earlier
+  // Leave has been accounted for by Enter at the same timestamp, processed earlier.
   if (event.timeStamp <= lastEnterTime) return
   event.currentTarget.closest("table").querySelectorAll(".dropzone").forEach((tr) => {
     tr.classList.remove("dropzone")
@@ -338,17 +244,22 @@ window.dragEnd = dragEnd
 
 function drop(event) {
   event.preventDefault()
-  var idParam = event.currentTarget.getAttribute("data-drop-id-param")
+
+  var params = new URLSearchParams()
+  var id_param = event.currentTarget.getAttribute("data-drop-id-param")
   var id = event.currentTarget.getAttribute("data-drop-id").split("_").pop()
-  var form = document.createElement('form');
-  form.action = event.dataTransfer.getData("text/plain");
-  form.method = 'post';
-  form.dataset.turboStream = 'true';
-  var input = document.createElement('input');
-  input.type = 'hidden'; input.name = idParam; input.value = id;
-  form.appendChild(input);
-  form.addEventListener('turbo:submit-end', function() { form.remove(); });
-  document.body.appendChild(form);
-  form.requestSubmit();
+  params.append(id_param, id)
+
+  fetch(event.dataTransfer.getData("text/plain"), {
+    body: params,
+    headers: {
+      "Accept": "text/vnd.turbo-stream.html",
+      "X-CSRF-Token": document.head.querySelector("meta[name=csrf-token]").content,
+      "X-Requested-With": "XMLHttpRequest"
+    },
+    method: "POST"
+  })
+  .then(response => response.text())
+  .then(html => Turbo.renderStreamMessage(html))
 }
 window.drop = drop

app/models/application_record.rb

@@ -1,4 +1,6 @@
 class ApplicationRecord < ActiveRecord::Base
+  include ActionView::Helpers::TagHelper
+
   class << self
     # Cached attribute has non-user assignable value calculated from other
     # attributes' values on create/update. This simplifies and speeds up

app/models/note.rb

@@ -0,0 +1,3 @@
+class Note < ApplicationRecord
+  ATTRIBUTES = [:text]
+end

app/models/quantity.rb

@@ -1,12 +1,12 @@
 class Quantity < ApplicationRecord
-  ATTRIBUTES = [:name, :description, :parent_id, :default_unit_id]
+  ATTRIBUTES = [:name, :description, :parent_id]
   attr_cached :depth, :pathname
 
   belongs_to :user, optional: true
   belongs_to :parent, optional: true, class_name: "Quantity"
-  belongs_to :default_unit, optional: true, class_name: "Unit"
   has_many :subquantities, ->{ order(:name) }, class_name: "Quantity",
     inverse_of: :parent, dependent: :restrict_with_error
+  has_many :readouts, dependent: :restrict_with_error
 
   validate if: ->{ parent.present? } do
     errors.add(:parent, :user_mismatch) unless user_id == parent.user_id
@@ -98,7 +98,7 @@ class Quantity < ApplicationRecord
   }
 
   def to_s
-    name
+    tag.pre name
   end
 
   def to_s_with_depth

app/models/readout.rb

@@ -1,7 +1,9 @@
 class Readout < ApplicationRecord
-  ATTRIBUTES = [:quantity_id, :value, :unit_id, :taken_at]
+  ATTRIBUTES = [:quantity_id, :value, :unit_id]
 
   belongs_to :user
   belongs_to :quantity
   belongs_to :unit
+
+  # TODO: validate quantity.user_id == unit.user_id != NULL
 end

app/models/unit.rb

@@ -1,5 +1,5 @@
 class Unit < ApplicationRecord
-  ATTRIBUTES = [:symbol, :description, :multiplier, :base_id]
+  ATTRIBUTES = {unit: [:symbol, :description, :multiplier, :base_id]}
 
   belongs_to :user, optional: true
   belongs_to :base, optional: true, class_name: "Unit"
@@ -14,8 +14,8 @@ class Unit < ApplicationRecord
   validates :symbol, presence: true, uniqueness: {scope: :user_id},
     length: {maximum: type_for_attribute(:symbol).limit}
   validates :description, length: {maximum: type_for_attribute(:description).limit}
-  validates :multiplier, numericality: {equal_to: 1}, unless: :base
-  validates :multiplier, numericality: {greater_than: 0, precision: true, scale: true}, if: :base
+  validates :multiplier, numericality: {equal_to: 1.0}, unless: :base
+  validates :multiplier, numericality: {greater_than: 0.0}, if: :base
 
   scope :defaults, ->{ where(user: nil) }
   scope :defaults_diff, ->{
@@ -77,15 +77,13 @@ class Unit < ApplicationRecord
       .from(units).group(:base_id, :symbol)
   }
   scope :ordered, ->{
-    left_outer_joins(:base).order(ordering)
-  }
-
-  def self.ordering
-    [arel_table.coalesce(Arel::Table.new(:bases_units)[:symbol], arel_table[:symbol]),
+    left_outer_joins(:base).order([
+      arel_table.coalesce(Arel::Table.new(:bases_units)[:symbol], arel_table[:symbol]),
       arel_table[:base_id].not_eq(nil),
-     :multiplier,
-     :symbol]
-  end
+      arel_table[:multiplier],
+      arel_table[:symbol]
+    ])
+  }
 
   before_destroy do
     # TODO: disallow destruction if any object depends on this unit
@@ -93,7 +91,7 @@ class Unit < ApplicationRecord
   end
 
   def to_s
-    symbol
+    tag.pre symbol
   end
 
   def movable?
@@ -104,21 +102,21 @@ class Unit < ApplicationRecord
     user_id.nil?
   end
 
-  # Should only by invoked on Units returned from #defaults_diff which are #portable
+  # Should only by invoked on Units returned from #defaults_diff which are #portable.
   def port!(recipient)
     recipient_base = base && Unit.find_by!(symbol: base.symbol, user: recipient)
-    params = slice(ATTRIBUTES - [:symbol, :base_id])
+    params = slice(ATTRIBUTES[:unit] - [:symbol, :base_id])
     Unit.find_or_initialize_by(user: recipient, symbol: symbol)
       .update!(base: recipient_base, **params)
   end
 
   def successive
     units = Unit.arel_table
-    lead = Arel::Nodes::NamedFunction.new('LAG', [units[:id]])
-    window = Arel::Nodes::Window.new.order(*Unit.ordering)
-    lag_id = lead.over(window).as('lag_id')
-    Unit.with(
-      units: user.units.left_outer_joins(:base).select(units[Arel.star], lag_id)
-    ).where(units[:lag_id].eq(id)).first
+    Unit.with(units_with_lag: user.units.left_outer_joins(:base).select(
+      units[Arel.star],
+      Arel::Nodes::NamedFunction.new('LAG', [units[:id]])
+        .over(Arel::Nodes::Window.new.order(Unit.ordered.order_values)).as('lag_id')
+    )).from(Arel::Table.new(:units_with_lag).as(:units))
+      .where(units[:lag_id].eq(id)).take
   end
 end

app/views/charts/index.html.erb

@@ -1,2 +0,0 @@
-<div class="main-area" id="measurements-charts"></div>
-<script id="charts-data" type="application/json"><%= raw @readouts_json %></script>

app/views/layouts/application.html.erb

@@ -14,7 +14,6 @@
     <%= csp_meta_tag %>
 
     <%= stylesheet_link_tag "spreadsheet" %>
-    <script src="https://cdn.plot.ly/plotly-basic-2.35.2.min.js"></script>
     <%= javascript_importmap_tags %>
 
     <%#= turbo_page_requires_reload_tag %>

app/views/measurements/_edit_form.html.erb

@@ -1,24 +0,0 @@
-<%= tabular_fields_for @readout, form: form_tag do |form| %>
-  <%- tag.tr id: row, class: "form", onkeydown: "formProcessKey(event)",
-    data: {form: form_tag, hidden_row: hidden_row, link: link} do %>
-    <td><%= @readout.quantity %></td>
-    <td class="ralign">
-      <%= form.number_field :value, required: true, autofocus: true %>
-    </td>
-    <td>
-      <%= form.collection_select :unit_id, @user_units, :id,
-        ->(u){ sanitize('&emsp;' * (u.base_id? ? 1 : 0) + u.symbol) },
-        {}, required: true %>
-    </td>
-    <td>
-      <%= form.datetime_field :taken_at %>
-    </td>
-    <td></td>
-    <td class="flex">
-      <%= form.button %>
-      <%= image_link_to t(:cancel), "close-outline", measurements_path,
-        class: 'dangerous', name: :cancel,
-        onclick: render_turbo_stream('edit_form_close', {row: row}) %>
-    </td>
-  <% end %>
-<% end %>

app/views/measurements/_edit_form_close.html.erb

@@ -1,2 +0,0 @@
-<%= turbo_stream.close_form row %>
-<%= turbo_stream.update :flashes %>

app/views/measurements/_edit_panel.html.erb

@@ -1,33 +0,0 @@
-<% form_tag = dom_id(@readout, :edit, :form) %>
-<% row = dom_id(@readout, :edit) %>
-<% hidden_row = dom_id(@readout) %>
-
-<%= tabular_form_with model: @readout, url: measurement_path(@readout),
-  id: form_tag do |form| %>
-  <table class="items-table">
-    <tbody>
-      <%= tag.tr id: row, class: "form", onkeydown: "formProcessKey(event)",
-        data: {form: form_tag, hidden_row: hidden_row} do %>
-        <td><%= @readout.quantity %></td>
-        <td class="ralign">
-          <%= form.number_field :value, required: true, autofocus: true %>
-        </td>
-        <td>
-          <%= form.collection_select :unit_id, @user_units, :id,
-            ->(u){ sanitize('&emsp;' * (u.base_id? ? 1 : 0) + u.symbol) },
-            {}, required: true %>
-        </td>
-        <td>
-          <%= form.datetime_field :taken_at %>
-        </td>
-        <td></td>
-        <td class="flex">
-          <%= form.button %>
-          <%= image_link_to t(:cancel), "close-outline", measurements_path,
-            class: 'dangerous', name: :cancel,
-            onclick: render_turbo_stream('edit_form_close', {row: row}) %>
-        </td>
-      <% end %>
-    </tbody>
-  </table>
-<% end %>

app/views/measurements/_form.html.erb

@@ -8,7 +8,7 @@
         <tr class="italic">
           <td class="hexpand hmin50"><%= t '.taken_at_html' %></td>
           <td colspan="3" class="ralign">
-            <%= form.datetime_field :taken_at, required: true, value: Time.current.strftime('%Y-%m-%dT%H:%M') %>
+            <%= form.datetime_field :taken_at, required: true %>
           </td>
         </tr>
       <% end %>
@@ -33,7 +33,7 @@
   <div class="flex reverse">
     <%= form.button id: :create_measurement_button, disabled: true -%>
     <%= image_link_to t(:cancel), "close-outline", measurements_path, name: :cancel,
-      class: 'dangerous', onclick: render_turbo_stream('form_close') %>
+      class: 'auxiliary dangerous', onclick: render_turbo_stream('form_close') %>
   </div>
 <% end %>
 

app/views/measurements/_readout.html.erb

@@ -1,22 +0,0 @@
-<%= tag.tr id: dom_id(readout), data: {taken_at: readout.taken_at&.iso8601,
-  quantity_id: readout.quantity_id, quantity_name: readout.quantity.name,
-  value: format("%.10g", readout.value), unit: readout.unit.symbol} do %>
-  <td>
-    <% if current_user.at_least(:active) %>
-      <%= link_to readout.quantity, edit_measurement_path(readout),
-        class: 'link', onclick: 'this.blur();', data: {turbo_stream: true} %>
-    <% else %>
-      <%= readout.quantity %>
-    <% end %>
-  </td>
-  <td class="ralign"><%= format("%.10g", readout.value) %></td>
-  <td><%= readout.unit %></td>
-  <td class="taken-at"><%= l(readout.taken_at) if readout.taken_at %></td>
-  <td class="created-at"><%= l(readout.created_at) %></td>
-  <% if current_user.at_least(:active) %>
-    <td class="flex">
-      <%= image_button_to t('.destroy'), 'delete-outline', measurement_path(readout),
-        method: :delete, data: {turbo_stream: true} %>
-    </td>
-  <% end %>
-<% end %>

app/views/measurements/_wide_table.html.erb

@@ -1,41 +0,0 @@
-<table class="items-table">
-  <thead>
-    <tr>
-      <th><%= Readout.human_attribute_name(:taken_at) %></th>
-      <% wide_quantities.each do |q| %>
-        <th><%= q.name %></th>
-      <% end %>
-      <th><%= Readout.human_attribute_name(:created_at) %></th>
-    </tr>
-  </thead>
-  <tbody>
-    <% wide_groups.each do |taken_at, readouts| %>
-      <tr>
-        <td><%= l(taken_at) if taken_at %></td>
-        <% wide_quantities.each do |q| %>
-          <% readout = readouts.find { |r| r.quantity_id == q.id } %>
-          <td class="ralign">
-            <% if readout %>
-              <span class="wide-cell">
-                <% if current_user.at_least(:active) %>
-                  <%= link_to format("%.10g", readout.value),
-                    edit_measurement_path(readout, view: :wide),
-                    class: 'link', onclick: 'this.blur();',
-                    data: {turbo_stream: true} %>
-                <% else %>
-                  <%= format("%.10g", readout.value) %>
-                <% end %>
-                &nbsp;<%= readout.unit.symbol %>
-                <% if current_user.at_least(:active) %>
-                  <%= image_button_to '', 'delete-outline', measurement_path(readout),
-                    method: :delete, data: {turbo_stream: true} %>
-                <% end %>
-              </span>
-            <% end %>
-          </td>
-        <% end %>
-        <td><%= l(readouts.first.created_at) %></td>
-      </tr>
-    <% end %>
-  </tbody>
-</table>

app/views/measurements/create.turbo_stream.erb

@@ -1,13 +0,0 @@
-<% if @readouts.present? && @readouts.all?(&:persisted?) %>
-  <%= turbo_stream.update :flashes %>
-  <%= turbo_stream.remove :measurement_form %>
-  <%= turbo_stream.enable :new_measurement_link %>
-  <%= turbo_stream.remove :no_items %>
-  <% @readouts.each do |readout| %>
-    <%= turbo_stream.prepend :measurements, partial: 'readout', locals: {readout: readout} %>
-  <% end %>
-  <%= turbo_stream.update 'measurements-wide', partial: 'wide_table',
-    locals: {wide_groups: @wide_groups, wide_quantities: @wide_quantities} %>
-<% else %>
-  <%= turbo_stream.update :flashes %>
-<% end %>

app/views/measurements/destroy.turbo_stream.erb

@@ -1,5 +0,0 @@
-<%= turbo_stream.update :flashes %>
-<%= turbo_stream.remove @readout %>
-<%= turbo_stream.append(:measurements, render_no_items) if current_user.readouts.empty? %>
-<%= turbo_stream.update 'measurements-wide', partial: 'wide_table',
-  locals: {wide_groups: @wide_groups, wide_quantities: @wide_quantities} %>

app/views/measurements/edit.turbo_stream.erb

@@ -1,18 +0,0 @@
-<% ids = {row: dom_id(@readout, :edit),
-          hidden_row: dom_id(@readout),
-          link: nil,
-          form_tag: dom_id(@readout, :edit, :form)} %>
-
-<% if params[:view] == 'wide' %>
-  <%= turbo_stream.update :measurement_edit_form, partial: 'edit_panel' %>
-  <%= turbo_stream.hide ids[:hidden_row] %>
-<% else %>
-  <%= turbo_stream.append :measurement_edit_form do %>
-    <%- tabular_form_with model: @readout, url: measurement_path(@readout),
-      html: {id: ids[:form_tag]} do %>
-    <% end %>
-  <% end %>
-  <%= turbo_stream.hide ids[:hidden_row] %>
-  <%= turbo_stream.remove ids[:row] %>
-  <%= turbo_stream.after @readout, partial: 'edit_form', locals: ids -%>
-<% end %>

app/views/measurements/index.html.erb

@@ -5,37 +5,10 @@
       id: :new_measurement_link, onclick: 'this.blur();',
       data: {turbo_stream: true} %>
   <% end %>
-  <%= image_button_tag '', 'view-rows', name: nil, type: 'button',
-    class: 'view-toggle', title: t('.view_compact'),
-    data: {view: 'compact'}, onclick: "setMeasurementsView('compact')" %>
-  <%= image_button_tag '', 'view-columns', name: nil, type: 'button',
-    class: 'view-toggle', title: t('.view_wide'),
-    data: {view: 'wide'}, onclick: "setMeasurementsView('wide')" %>
-
 </div>
 
-<div class="main-area measurements-section">
-  <%= tag.div id: :measurement_edit_form %>
-  <table class="items-table measurements-compact">
-    <thead>
-      <tr>
-        <th><%= Quantity.model_name.human %></th>
-        <th><%= Readout.human_attribute_name(:value) %></th>
-        <th><%= Unit.model_name.human %></th>
-        <th data-column="taken-at"><%= Readout.human_attribute_name(:taken_at) %></th>
-        <th data-column="created-at"><%= Readout.human_attribute_name(:created_at) %></th>
-        <% if current_user.at_least(:active) %>
-          <th></th>
-        <% end %>
-      </tr>
-    </thead>
+<table class="main-area">
   <tbody id="measurements">
-      <%= render(partial: 'readout', collection: @measurements, as: :readout) || render_no_items %>
+    <%= render(@measurements) || render_no_items %>
   </tbody>
-  </table>
-
-  <div id="measurements-wide" class="measurements-wide">
-    <%= render 'wide_table', wide_groups: @wide_groups, wide_quantities: @wide_quantities %>
-  </div>
-</div>
-
+</table>

app/views/measurements/update.turbo_stream.erb

@@ -1,4 +0,0 @@
-<%= turbo_stream.close_form dom_id(@readout, :edit) %>
-<%= turbo_stream.replace @readout, partial: 'measurements/readout', locals: {readout: @readout} %>
-<%= turbo_stream.update 'measurements-wide', partial: 'wide_table',
-  locals: {wide_groups: @wide_groups, wide_quantities: @wide_quantities} %>

app/views/quantities/_form.html.erb

@@ -8,11 +8,6 @@
     <td>
       <%= form.text_area :description, cols: 30, rows: 1, escape: false %>
     </td>
-    <td>
-      <%= form.collection_select :default_unit_id, @user_units, :id,
-        ->(u){ sanitize('&emsp;' * (u.base_id? ? 1 : 0) + u.symbol) },
-        {include_blank: true}, onchange: "this.dataset.changed = ''" %>
-    </td>
 
     <td class="flex">
       <%= form.button %>

app/views/quantities/_quantity.html.erb

@@ -10,7 +10,6 @@
       onclick: 'this.blur();', data: {turbo_stream: true} %>
   </td>
   <td><%= quantity.description %></td>
-  <td><%= quantity.default_unit&.symbol %></td>
 
   <% if current_user.at_least(:active) %>
     <td class="flex">

app/views/quantities/index.html.erb

@@ -16,7 +16,6 @@
     <tr>
       <th><%= Quantity.human_attribute_name(:name) %></th>
       <th class="hexpand"><%= Quantity.human_attribute_name(:description) %></th>
-      <th><%= Quantity.human_attribute_name(:default_unit) %></th>
       <% if current_user.at_least(:active) %>
         <th><%= t :actions %></th>
         <th></th>
@@ -26,7 +25,7 @@
                ondragover: "dragOver(event)", ondrop: "drop(event)",
                ondragenter: "dragEnter(event)", ondragleave: "dragLeave(event)",
                data: {drop_id: "quantity_", drop_id_param: "quantity[parent_id]"} do %>
-      <th colspan="5"><%= t '.top_level_drop' %></th>
+      <th colspan="4"><%= t '.top_level_drop' %></th>
     <% end %>
   </thead>
   <tbody id="quantities">

app/views/readouts/_form.html.erb

@@ -12,17 +12,10 @@
     <td>
       <%= form.collection_select :unit_id, @user_units, :id,
         ->(u){ sanitize('&emsp;' * (u.base_id ? 1 : 0) + u.symbol) },
-        {prompt: '', disabled: '', selected: readout.quantity.default_unit_id || ''}, required: true,
-        data: {default_unit_id: readout.quantity.default_unit_id || ''},
-        onchange: "readoutUnitChanged(this)" %>
+        {prompt: '', disabled: '', selected: ''}, required: true %>
     </td>
     <td class="flex">
       <%# TODO: change to _link_ after giving up displaying relative paths %>
-      <%= image_button_tag '', 'check-circle-outline',
-        class: 'set-default-unit', name: nil, type: 'button', disabled: true,
-        title: t('readouts.form.set_default_unit'),
-        data: {path: quantity_path(readout.quantity)},
-        onclick: 'setDefaultUnit(this)' %>
       <%= image_button_tag '', 'delete-outline', class: 'dangerous', name: nil,
         formaction: discard_readouts_path(readout.quantity),
         formmethod: :get, formnovalidate: true, data: {turbo_stream: true} %>

app/views/units/_form.html.erb

@@ -9,7 +9,7 @@
       <%= form.text_area :description, cols: 30, rows: 1, escape: false %>
     </td>
     <td>
-      <%= form.number_field :multiplier, required: true, size: 10, min: :step if @unit.base_id? %>
+      <%= form.number_field :multiplier, required: true if @unit.base_id? %>
     </td>
 
     <td class="flex">

app/views/units/_unit.html.erb

@@ -11,7 +11,7 @@
       data: {turbo_stream: true} %>
   </td>
   <td><%= unit.description %></td>
-  <td class="ralign"><%= unit.multiplier.to_html %></td>
+  <td class="ralign"><%= unit.multiplier.to_html if unit.base_id? %></td>
 
   <% if current_user.at_least(:active) %>
     <td class="flex">

app/views/units/rebase.turbo_stream.erb

@@ -1,4 +1,4 @@
 <%= turbo_stream.remove @unit %>
 <%= turbo_stream.replace @previous_base if @previous_base %>
-<%= turbo_stream.replace @unit.base if @unit.base_id? && (@previous_base.id != @unit.base_id) %>
+<%= turbo_stream.replace @unit.base if @unit.base_id? && (@previous_base&.id != @unit.base_id) %>
 <%= @before ? turbo_stream.before(@before, @unit) : turbo_stream.append(:units, @unit) %>

app/views/users/index.html.erb

@@ -4,7 +4,7 @@
       <th><%= User.human_attribute_name(:email) %></th>
       <th><%= User.human_attribute_name(:status) %></th>
       <th><%= User.human_attribute_name(:confirmed_at) %></th>
-      <th><%= User.human_attribute_name(:created_at) %>&nbsp;<sup>(UTC)</sup></th>
+      <th><pre><%= User.human_attribute_name(:created_at) %> <sup>(UTC)</sup></pre></th>
       <th><%= t :actions %></th>
     </tr>
   </thead>
@@ -22,10 +22,8 @@
             <% end %>
           <% end %>
         </td>
-        <td>
-          <%= svg_tag 'pictograms/checkbox-marked-outline' if user.confirmed_at.present? %>
-        </td>
-        <td><%= l user.created_at, format: :without_tz %></td>
+        <td><%= svg_tag 'checkbox-marked-outline' if user.confirmed_at.present? %></td>
+        <td><pre><%= l user.created_at, format: :without_tz %></pre></td>
         <td class="flex">
           <% if allow_disguise?(user) %>
             <%= image_link_to t('.disguise'), 'incognito', disguise_user_path(user) %>

app/views/users/profiles/edit.html.erb

@@ -1,5 +1,5 @@
 <% content_for :navigation, flush: true do %>
-  <%= link_to svg_tag('pictograms/arrow-left-bold-outline', t(:back)),
+  <%= link_to svg_tag('arrow-left-bold-outline', t(:back)),
     request.referer.present? ? :back : root_path, class: 'tab' %>
 <% end %>
 

app/views/users/show.html.erb

@@ -1,6 +1,5 @@
 <% content_for :navigation, flush: true do %>
-  <%= link_to svg_tag('pictograms/arrow-left-bold-outline', t(:back)), users_path,
-    class: 'tab' %>
+  <%= link_to svg_tag('arrow-left-bold-outline', t(:back)), users_path, class: 'tab' %>
 <% end %>
 
 <%= labeled_form_for @user, html: {class: 'main-area'} do |f| %>

bin/ci

@@ -0,0 +1,6 @@
+#!/usr/bin/env ruby
+require_relative "../config/boot"
+require "active_support/continuous_integration"
+
+CI = ActiveSupport::ContinuousIntegration
+require_relative "../config/ci.rb"

bin/dev

@@ -0,0 +1,2 @@
+#!/usr/bin/env ruby
+exec "./bin/rails", "server", *ARGV

bin/setup

@@ -1,11 +1,10 @@
 #!/usr/bin/env ruby
 require "fileutils"
 
-# path to your application root.
 APP_ROOT = File.expand_path("..", __dir__)
 
 def system!(*args)
-  system(*args) || abort("\n== Command #{args} failed ==")
+  system(*args, exception: true)
 end
 
 FileUtils.chdir APP_ROOT do
@@ -14,7 +13,6 @@ FileUtils.chdir APP_ROOT do
   # Add necessary setup steps to this file.
 
   puts "== Installing dependencies =="
-  system! "gem install bundler --conservative"
   system("bundle check") || system!("bundle install")
 
   # puts "\n== Copying sample files =="
@@ -24,10 +22,14 @@ FileUtils.chdir APP_ROOT do
 
   puts "\n== Preparing database =="
   system! "bin/rails db:prepare"
+  system! "bin/rails db:reset" if ARGV.include?("--reset")
 
   puts "\n== Removing old logs and tempfiles =="
   system! "bin/rails log:clear tmp:clear"
 
-  puts "\n== Restarting application server =="
-  system! "bin/rails restart"
+  unless ARGV.include?("--skip-server")
+    puts "\n== Starting development server =="
+    STDOUT.flush # flush the output before exec(2) so that it displays
+    exec "bin/dev"
+  end
 end

config/application.rb.dist

@@ -18,14 +18,17 @@ require "rails/test_unit/railtie"
 # you've limited to :test, :development, or :production.
 Bundler.require(*Rails.groups)
 
+require_relative '../lib/default_settings_strategy'
+
 module FixinMe
   class Application < Rails::Application
     # Initialize configuration defaults for originally generated Rails version.
-    config.load_defaults 7.0
+    config.load_defaults 8.1
 
-    # Autoload lib/, required e.g. for core library extensions.
-    # https://guides.rubyonrails.org/autoloading_and_reloading_constants.html#config-autoload-lib-ignore.
-    config.autoload_lib(ignore: %w(assets tasks))
+    # Please, add to the `ignore` list any other `lib` subdirectories that do
+    # not contain `.rb` files, or that should not be reloaded or eager loaded.
+    # Common ones are `templates`, `generators`, or `middleware`, for example.
+    config.autoload_lib(ignore: %w[assets tasks])
 
     # Configuration for the application, engines, and railties goes here.
     #
@@ -38,16 +41,19 @@ module FixinMe
     config.action_dispatch.rescue_responses['ApplicationController::AccessForbidden'] = :forbidden
     config.action_dispatch.rescue_responses['ApplicationController::ParameterInvalid'] = :unprocessable_entity
 
+    # Set default migrations parameters.
+    config.active_record.migration_strategy = DefaultSettingsStrategy
+
     # SETUP: Below settings need to be updated on a per-installation basis.
     #
-    # URL to use in sent e-mails.
-    config.action_mailer.default_url_options = {host: 'localhost', :protocol => 'https'}
+    # Set host to be used by links generated in mailer templates.
+    config.action_mailer.default_url_options = {host: 'localhost', protocol: 'https'}
     # https://guides.rubyonrails.org/configuring.html#config-action-mailer-delivery-method
     config.action_mailer.delivery_method = :sendmail
 
     # List of hosts this app is available at.
     # https://guides.rubyonrails.org/configuring.html#actiondispatch-hostauthorization
-    config.hosts += ['localhost', 'example.com', IPAddr.new('1.2.3.4/32')]
+    config.hosts |= ['localhost']
 
     # Email address of admin account
     config.admin = 'admin@localhost'

config/ci.rb

@@ -0,0 +1,20 @@
+# Run using bin/ci
+
+CI.run do
+  step "Setup", "bin/setup --skip-server"
+
+  step "Security: Importmap vulnerability audit", "bin/importmap audit"
+  step "Tests: Rails", "bin/rails test"
+  step "Tests: Seeds", "env RAILS_ENV=test bin/rails db:seed:replant"
+
+  # Optional: Run system tests
+  # step "Tests: System", "bin/rails test:system"
+
+  # Optional: set a green GitHub commit status to unblock PR merge.
+  # Requires the `gh` CLI and `gh extension install basecamp/gh-signoff`.
+  # if success?
+  #   step "Signoff: All systems go. Ready for merge and deploy.", "gh signoff"
+  # else
+  #   failure "Signoff: CI failed. Do not merge or deploy.", "Fix the issues and try again."
+  # end
+end

config/database.yml.dist

@@ -24,27 +24,45 @@
 # Read https://guides.rubyonrails.org/configuring.html#configuring-a-database
 # for a full overview on how database connection configuration can be specified.
 default: &default
-  adapter: mysql2
-  encoding: utf8mb4
-  collation: utf8mb4_0900_as_ci
-  pool: <%= ENV.fetch("RAILS_MAX_THREADS") { 5 } %>
-  username: fixinme
-  password: Some-password1%
-  socket: /run/mysqld/mysqld.sock
+  pool: <%= ENV.fetch('RAILS_MAX_THREADS', 3) %>
+
+#mysql_default: &mysql_default
+#  <<: *default
+#  username: fixinme
+#  password: Some-password1%
+#  host: 127.0.0.1
+#  encoding: utf8mb4
+#  collation: utf8mb4_0900_as_ci
 
 production:
   <<: *default
-  database: fixinme
+  adapter: sqlite3
+  database: db/production.sqlite3
 
-# Unless you're planning on developing the application, you can skip
+# Unless you're planning on developing the application, you can skip/remove
 # configurations for development and test databases altogether.
 #development:
-#  <<: *default
+#  <<: *mysql_default
+#  adapter: mysql2
 #  database: fixinme_dev
 
-# Warning: The database defined as "test" will be erased and
+# Warning: The database(s) defined as "test" will be erased and
 # re-generated from your development database when you run "rake".
 # Do not set this db to the same as development or production.
 #test:
-#  <<: *default
+#  <<: *mysql_default
+#  adapter: mysql2
 #  database: fixinme_test
+
+# Multiple test databases can be provided. When more than one test db is
+# present, every test task (test, test:models, test:system, etc.) runs against
+# all of them.
+#test:
+#  mysql2:
+#    <<: *mysql_default
+#    adapter: mysql2
+#    database: fixinme_test
+#  sqlite3:
+#    <<: *default
+#    adapter: sqlite3
+#    database: db/test.sqlite3

config/environments/development.rb

@@ -3,10 +3,8 @@ require "active_support/core_ext/integer/time"
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 
-  # In the development environment your application's code is reloaded any time
-  # it changes. This slows down response time but is perfect for development
-  # since you don't have to restart the web server when you make code changes.
-  config.cache_classes = false
+  # Make code changes take effect immediately without server restart.
+  config.enable_reloading = true
 
   # Do not eager load code on boot.
   config.eager_load = false
@@ -14,54 +12,52 @@ Rails.application.configure do
   # Show full error reports.
   config.consider_all_requests_local = true
 
-  # Enable server timing
+  # Enable server timing.
   config.server_timing = true
 
-  # Enable/disable caching. By default caching is disabled.
-  # Run rails dev:cache to toggle caching.
+  # Enable/disable Action Controller caching. By default Action Controller caching is disabled.
+  # Run rails dev:cache to toggle Action Controller caching.
   if Rails.root.join("tmp/caching-dev.txt").exist?
     config.action_controller.perform_caching = true
     config.action_controller.enable_fragment_cache_logging = true
-
-    config.cache_store = :memory_store
-    config.public_file_server.headers = {
-      "Cache-Control" => "public, max-age=#{2.days.to_i}"
-    }
+    config.public_file_server.headers = { "cache-control" => "public, max-age=#{2.days.to_i}" }
   else
     config.action_controller.perform_caching = false
-
-    config.cache_store = :null_store
   end
 
+  # Change to :null_store to avoid any caching.
+  config.cache_store = :memory_store
+
   # Don't care if the mailer can't send.
   config.action_mailer.raise_delivery_errors = false
 
+  # Make template changes take effect immediately.
   config.action_mailer.perform_caching = false
 
   # Print deprecation notices to the Rails logger.
   config.active_support.deprecation = :log
 
-  # Raise exceptions for disallowed deprecations.
-  config.active_support.disallowed_deprecation = :raise
-
-  # Tell Active Support which deprecation messages to disallow.
-  config.active_support.disallowed_deprecation_warnings = []
-
   # Raise an error on page load if there are pending migrations.
   config.active_record.migration_error = :page_load
 
   # Highlight code that triggered database queries in logs.
   config.active_record.verbose_query_logs = true
 
-  # Suppress logger output for asset requests.
-  config.assets.quiet = true
+  # Append comments with runtime information tags to SQL queries in logs.
+  config.active_record.query_log_tags_enabled = true
+
+  # Highlight code that enqueued background job in logs.
+  config.active_job.verbose_enqueue_logs = true
+
+  # Highlight code that triggered redirect in logs.
+  config.action_dispatch.verbose_redirect_logs = true
 
   # Raises error for missing translations.
   # config.i18n.raise_on_missing_translations = true
 
   # Annotate rendered view with file names.
-  # config.action_view.annotate_rendered_view_with_filenames = true
+  config.action_view.annotate_rendered_view_with_filenames = true
 
-  # Uncomment if you wish to allow Action Cable access from any origin.
-  # config.action_cable.disable_request_forgery_protection = true
+  # Raise error when a before_action's only/except options reference missing actions.
+  config.action_controller.raise_on_missing_callback_actions = true
 end

config/environments/production.rb

@@ -4,78 +4,83 @@ Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 
   # Code is not reloaded between requests.
-  config.cache_classes = true
+  config.enable_reloading = false
 
-  # Eager load code on boot. This eager loads most of Rails and
-  # your application in memory, allowing both threaded web servers
-  # and those relying on copy on write to perform better.
-  # Rake tasks automatically ignore this option for performance.
+  # Eager load code on boot for better performance and memory savings (ignored by Rake tasks).
   config.eager_load = true
 
-  # Full error reports are disabled and caching is turned on.
+  # Full error reports are disabled.
   config.consider_all_requests_local = false
+
+  # Turn on fragment caching in view templates.
   config.action_controller.perform_caching = true
 
-  # Ensures that a master key has been made available in either ENV["RAILS_MASTER_KEY"]
-  # or in config/master.key. This key is used to decrypt credentials (and other encrypted files).
-  # config.require_master_key = true
-
-  # Disable serving static files from the `/public` folder by default since
-  # Apache or NGINX already handles this.
-  config.public_file_server.enabled = ENV["RAILS_SERVE_STATIC_FILES"].present?
-
-  # Compress CSS using a preprocessor.
-  # config.assets.css_compressor = :sass
-
-  # Do not fallback to assets pipeline if a precompiled asset is missed.
-  config.assets.compile = false
+  # Cache assets for far-future expiry since they are all digest stamped.
+  config.public_file_server.headers = { "cache-control" => "public, max-age=#{1.year.to_i}" }
 
   # Enable serving of images, stylesheets, and JavaScripts from an asset server.
   # config.asset_host = "http://assets.example.com"
 
-  # Specifies the header that your server uses for sending files.
-  # config.action_dispatch.x_sendfile_header = "X-Sendfile" # for Apache
-  # config.action_dispatch.x_sendfile_header = "X-Accel-Redirect" # for NGINX
+  # Assume all access to the app is happening through a SSL-terminating reverse proxy.
+  config.assume_ssl = true
 
   # Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies.
-  # config.force_ssl = true
+  config.force_ssl = true
 
-  # Include generic and useful information about system operation, but avoid logging too much
-  # information to avoid inadvertent exposure of personally identifiable information (PII).
-  config.log_level = :info
+  # Skip http-to-https redirect for the default health check endpoint.
+  # config.ssl_options = { redirect: { exclude: ->(request) { request.path == "/up" } } }
 
-  # Prepend all log lines with the following tags.
+  # Log to STDOUT with the current request id as a default log tag.
   config.log_tags = [ :request_id ]
+  config.logger   = ActiveSupport::TaggedLogging.logger(STDOUT)
 
-  # Use a different cache store in production.
+  # Change to "debug" to log everything (including potentially personally-identifiable information!).
+  config.log_level = ENV.fetch("RAILS_LOG_LEVEL", "info")
+
+  # Prevent health checks from clogging up the logs.
+  config.silence_healthcheck_path = "/up"
+
+  # Don't log any deprecations.
+  config.active_support.report_deprecations = false
+
+  # Replace the default in-process memory cache store with a durable alternative.
   # config.cache_store = :mem_cache_store
 
-  config.action_mailer.perform_caching = false
+  # Replace the default in-process and non-durable queuing backend for Active Job.
+  # config.active_job.queue_adapter = :resque
 
   # Ignore bad email addresses and do not raise email delivery errors.
   # Set this to true and configure the email server for immediate delivery to raise delivery errors.
   # config.action_mailer.raise_delivery_errors = false
 
+  # Specify outgoing SMTP server. Remember to add smtp/* credentials via bin/rails credentials:edit.
+  # config.action_mailer.smtp_settings = {
+  #   user_name: Rails.application.credentials.dig(:smtp, :user_name),
+  #   password: Rails.application.credentials.dig(:smtp, :password),
+  #   address: "smtp.example.com",
+  #   port: 587,
+  #   authentication: :plain
+  # }
+
   # Enable locale fallbacks for I18n (makes lookups for any locale fall back to
   # the I18n.default_locale when a translation cannot be found).
   config.i18n.fallbacks = true
 
-  # Don't log any deprecations.
-  config.active_support.report_deprecations = false
-
-  # Use default logging formatter so that PID and timestamp are not suppressed.
-  config.log_formatter = ::Logger::Formatter.new
-
-  # Use a different logger for distributed setups.
-  # require "syslog/logger"
-  # config.logger = ActiveSupport::TaggedLogging.new(Syslog::Logger.new "app-name")
-
-  if ENV["RAILS_LOG_TO_STDOUT"].present?
-    logger           = ActiveSupport::Logger.new(STDOUT)
-    logger.formatter = config.log_formatter
-    config.logger    = ActiveSupport::TaggedLogging.new(logger)
-  end
-
   # Do not dump schema after migrations.
   config.active_record.dump_schema_after_migration = false
+
+  # Only use :id for inspections in production.
+  config.active_record.attributes_for_inspect = [ :id ]
+
+  # Enable DNS rebinding protection and other `Host` header attacks.
+  # config.hosts = [
+  #   "example.com",     # Allow requests from example.com
+  #   /.*\.example\.com/ # Allow requests from subdomains like `www.example.com`
+  # ]
+  #
+  # Skip DNS rebinding protection for the default health check endpoint.
+  # config.host_authorization = { exclude: ->(request) { request.path == "/up" } }
+
+  # Protect e-mail addresses from being logged only in production.
+  config.filter_parameters += [:email]
 end

config/environments/test.rb

@@ -1,5 +1,3 @@
-require "active_support/core_ext/integer/time"
-
 # The test environment is used exclusively to run your application's
 # test suite. You never need to work with it otherwise. Remember that
 # your test database is "scratch space" for the test suite and is wiped
@@ -8,57 +6,49 @@ require "active_support/core_ext/integer/time"
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 
-  # Turn false under Spring and add config.action_view.cache_template_loading = true.
-  config.cache_classes = true
+  # While tests run files are not watched, reloading is not necessary.
+  config.enable_reloading = false
 
-  # Eager loading loads your whole application. When running a single test locally,
-  # this probably isn't necessary. It's a good idea to do in a continuous integration
-  # system, or in some way before deploying your code.
+  # Eager loading loads your entire application. When running a single test locally,
+  # this is usually not necessary, and can slow down your test suite. However, it's
+  # recommended that you enable it in continuous integration systems to ensure eager
+  # loading is working properly before deploying your code.
   config.eager_load = ENV["CI"].present?
 
-  # Configure public file server for tests with Cache-Control for performance.
-  config.public_file_server.enabled = true
-  config.public_file_server.headers = {
-    "Cache-Control" => "public, max-age=#{1.hour.to_i}"
-  }
+  # Configure public file server for tests with cache-control for performance.
+  config.public_file_server.headers = { "cache-control" => "public, max-age=3600" }
 
-  # Hide full error reports.
+  # Behave as in `production`.
   config.consider_all_requests_local = false
-  # Render exception templates instead of raising exceptions.
-  config.action_dispatch.show_exceptions = :all
 
-  # Disable caching.
-  config.action_controller.perform_caching = false
   config.cache_store = :null_store
 
   # Disable request forgery protection in test environment.
   config.action_controller.allow_forgery_protection = false
 
-  config.action_mailer.perform_caching = false
-
   # Tell Action Mailer not to deliver emails to the real world.
   # The :test delivery method accumulates sent emails in the
   # ActionMailer::Base.deliveries array.
   config.action_mailer.delivery_method = :test
-  config.action_mailer.default_url_options = {host: '127.0.0.1', :protocol => 'http'}
+
+  # Set host to be used by links generated in mailer templates.
+  config.action_mailer.default_url_options = {host: Capybara.server_host,
+                                              protocol: 'http'}
 
   # Print deprecation notices to the stderr.
   config.active_support.deprecation = :stderr
 
-  # Raise exceptions for disallowed deprecations.
-  config.active_support.disallowed_deprecation = :raise
-
-  # Tell Active Support which deprecation messages to disallow.
-  config.active_support.disallowed_deprecation_warnings = []
-
   # Raises error for missing translations.
   config.i18n.raise_on_missing_translations = true
 
   # Annotate rendered view with file names.
   # config.action_view.annotate_rendered_view_with_filenames = true
 
-  config.log_level = :info
+  # Raise error when a before_action's only/except options reference missing actions.
+  config.action_controller.raise_on_missing_callback_actions = true
 
-  # Allow Capybara's dynamic test server host (127.0.0.1:<random_port>)
-  config.hosts << '127.0.0.1'
+  # Allow Capybara application server IP
+  config.hosts |= [IPAddr.new(Capybara.server_host)]
+
+  config.log_level = :info
 end

config/initializers/assets.rb

@@ -5,8 +5,3 @@ Rails.application.config.assets.version = "1.0"
 
 # Add additional assets to the asset load path.
 # Rails.application.config.assets.paths << Emoji.images_path
-
-# Precompile additional assets.
-# application.js, application.css, and all non-JS/CSS in the app/assets
-# folder are already added.
-Rails.application.config.assets.precompile += %w( '*.svg' )

config/initializers/content_security_policy.rb

@@ -16,9 +16,13 @@
 #     # policy.report_uri "/csp-violation-report-endpoint"
 #   end
 #
-#   # Generate session nonces for permitted importmap and inline scripts
+#   # Generate session nonces for permitted importmap, inline scripts, and inline styles.
 #   config.content_security_policy_nonce_generator = ->(request) { request.session.id.to_s }
-#   config.content_security_policy_nonce_directives = %w(script-src)
+#   config.content_security_policy_nonce_directives = %w(script-src style-src)
+#
+#   # Automatically add `nonce` to `javascript_tag`, `javascript_include_tag`, and `stylesheet_link_tag`
+#   # if the corresponding directives are specified in `content_security_policy_nonce_directives`.
+#   # config.content_security_policy_nonce_auto = true
 #
 #   # Report violations without enforcing the policy.
 #   # config.content_security_policy_report_only = true

config/initializers/core_ext.rb

@@ -1,8 +1,12 @@
 require 'core_ext/array_delete_bang'
-require 'core_ext/big_decimal_scientific_notation'
+require 'core_ext/float'
+require 'core_ext/range'
 
 ActiveSupport.on_load :action_dispatch_system_test_case do
   prepend CoreExt::ActionDispatch::SystemTesting::TestHelpers::ScreenshotHelperUniqueId
+  # Allow denormalized string comparison,
+  # https://github.com/orgs/teamcapybara/discussions/2841
+  XPath::DSL.prepend CoreExt::XPath::DSL::NormalizeSpaceDefault
 end
 
 ActiveSupport.on_load :action_view do
@@ -11,7 +15,7 @@ end
 
 ActiveSupport.on_load :active_record do
   ActiveModel::Validations::NumericalityValidator
-    .prepend CoreExt::ActiveModel::Validations::NumericalityValidatesPrecisionAndScale
+    .prepend CoreExt::ActiveModel::Validations::NumericalityValidatesPrecision
 
   # Temporary patch for https://github.com/rails/rails/pull/54658
   Arel::TreeManager::StatementMethods

config/initializers/devise.rb

@@ -179,7 +179,7 @@ Devise.setup do |config|
 
   # ==> Configuration for :validatable
   # Range for password length.
-  config.password_length = 5..128
+  config.password_length = 5..32
 
   # Email regex used to validate email formats. It simply asserts that
   # one (and only one) @ exists in the given string. This is mainly

config/initializers/filter_parameter_logging.rb

@@ -1,8 +1,8 @@
 # Be sure to restart your server when you modify this file.
 
-# Configure parameters to be filtered from the log file. Use this to limit dissemination of
-# sensitive information. See the ActiveSupport::ParameterFilter documentation for supported
-# notations and behaviors.
+# Configure parameters to be partially matched (e.g. passw matches password) and filtered from the log file.
+# Use this to limit dissemination of sensitive information.
+# See the ActiveSupport::ParameterFilter documentation for supported notations and behaviors.
 Rails.application.config.filter_parameters += [
-  :passw, :secret, :token, :_key, :crypt, :salt, :certificate, :otp, :ssn
+  :passw, :secret, :token, :_key, :crypt, :salt, :certificate, :otp, :ssn, :cvv, :cvc
 ]

config/locales/en.yml

@@ -1,23 +1,16 @@
 en:
   time:
     formats:
-      # Format contains non-breaking space: 160.chr(Encoding::UTF_8)
-      default: "%Y-%m-%d %H:%M %Z"
-      without_tz: "%Y-%m-%d %H:%M"
+      default: "%Y-%m-%d %H:%M %Z"
+      without_tz: "%Y-%m-%d %H:%M"
   errors:
     messages:
-      precision_exceeded: must not exceed %{value} significant digits
-      scale_exceeded: must not exceed %{value} decimal digits
+      out_of_range: exceeds range of double precision floating-point format
   activerecord:
     attributes:
       quantity:
-        default_unit: Default unit
         description: Description
         name: Name
-      readout:
-        created_at: Recorded at
-        taken_at: Taken at
-        value: Value
       unit:
         base: Base unit
         description: Description
@@ -48,6 +41,24 @@ en:
               descendant_reference: cannot be changed to any of descendants
               self_reference: of the quantitiy cannot be the quantity itself
               user_mismatch: has to belong to the same user as quantity
+  activesupport:
+    # Based on: https://github.com/unicode-org/cldr-json/blob/main/cldr-json/cldr-misc-full/main/en/characters.json
+    characters:
+      subsets:
+        # :exemplarCharacters[EN]
+        exemplar: abcdefghijklmnopqrstuvwxyz
+        # :index[EN]
+        index: ABCDEFGHIJKLMNOPQRSTUVWXYZ
+        numbers: 0123456789
+        # :exemplarCharacters[DE, PL] - exemplarCharacters[EN] +
+        #   :index[DE, PL] - :index[EN]
+        auxiliary: äößüĆŁÓŚŹŻąćęłńóśźż
+        # :punctuation* + :numbers* - space - numbers
+        punctuation: >-
+          !\"#%&'()*+,-./:;?@[]{|}~§«°»×‐‑–—‘’‚“”„†‡…‰′″−
+        # :exemplarCharacters[EL] + :index[EL]
+        symbols: αάβγδεέζηήθιίϊΐκλμνξοόπρσςτυύϋΰφχψωώΑΒΓΔΕΖΗΘΙΚΛΜΝΞΟΠΡΣΤΥΦΧΨΩ
+        space: ' '
   actioncontroller:
     exceptions:
       status:
@@ -66,6 +77,7 @@ en:
   helpers:
     label:
       user:
+        # TODO: remove or reduce all unnecessarily singly and doubly quoted text
         password_confirmation: 'Retype new password:'
         password_length_hint_html:
           count: '%{minimum_password_length}'
@@ -86,11 +98,6 @@ en:
       revert: Revert
       sign_out: Sign out
       source_code: Get code
-  readouts:
-    form:
-      set_default_unit: Set as default unit
-  charts:
-    navigation: Charts
   measurements:
     navigation: Measurements
     no_items: There are no measurements taken. You can Add some now.
@@ -99,21 +106,6 @@ en:
       taken_at_html: Measurement taken at 
     index:
       new_measurement: Add measurement
-      view_compact: Compact view
-      view_wide: Wide view
-      view_charts: Charts
-    readout:
-      edit: Edit
-      destroy: Delete
-    create:
-      success:
-        one: Recorded 1 measurement.
-        other: Recorded %{count} measurements.
-      no_readouts: No readouts selected.
-    update:
-      success: Measurement updated.
-    destroy:
-      success: Measurement deleted.
   quantities:
     navigation: Quantities
     no_items: There are no configured quantities. You can Add some or Import from defaults.

config/puma.rb.dist

@@ -1,43 +1,41 @@
-# Puma can serve each request in a thread from an internal thread pool.
-# The `threads` method setting takes two numbers: a minimum and maximum.
-# Any libraries that use thread pools should be configured to match
-# the maximum value specified for Puma. Default is set to 5 threads for minimum
-# and maximum; this matches the default thread size of Active Record.
+# This configuration file will be evaluated by Puma. The top-level methods that
+# are invoked here are part of Puma's configuration DSL. For more information
+# about methods provided by the DSL, see https://puma.io/puma/Puma/DSL.html.
 #
-max_threads_count = ENV.fetch("RAILS_MAX_THREADS") { 5 }
-min_threads_count = ENV.fetch("RAILS_MIN_THREADS") { max_threads_count }
-threads min_threads_count, max_threads_count
-
-# Specifies the `worker_timeout` threshold that Puma will use to wait before
-# terminating a worker in development environments.
+# Puma starts a configurable number of processes (workers) and each process
+# serves each request in a thread from an internal thread pool.
 #
-worker_timeout 3600 if ENV.fetch("RAILS_ENV", "development") == "development"
+# You can control the number of workers using ENV["WEB_CONCURRENCY"]. You
+# should only set this value when you want to run 2 or more workers. The
+# default is already 1.
+#
+# The ideal number of threads per worker depends both on how much time the
+# application spends waiting for IO operations and on how much you wish to
+# prioritize throughput over latency.
+#
+# As a rule of thumb, increasing the number of threads will increase how much
+# traffic a given process can handle (throughput), but due to CRuby's
+# Global VM Lock (GVL) it has diminishing returns and will degrade the
+# response time (latency) of the application.
+#
+# The default is set to 3 threads as it's deemed a decent compromise between
+# throughput and latency for the average Rails application.
+#
+# Any libraries that use a connection pool or another resource pool should
+# be configured to provide at least as many connections as the number of
+# threads. This includes Active Record's `pool` parameter in `database.yml`.
+threads_count = ENV.fetch("RAILS_MAX_THREADS", 3)
+threads threads_count, threads_count
 
 # Specifies the `port` that Puma will listen on to receive requests; default is 3000.
-#
-port ENV.fetch("PORT") { 3000 }
-
-# Specifies the `environment` that Puma will run in.
-#
-environment ENV.fetch("RAILS_ENV") { "development" }
-
-# Specifies the `pidfile` that Puma will use.
-pidfile ENV.fetch("PIDFILE") { "tmp/pids/server.pid" }
-
-# Specifies the number of `workers` to boot in clustered mode.
-# Workers are forked web server processes. If using threads and workers together
-# the concurrency of the application would be max `threads` * `workers`.
-# Workers do not work on JRuby or Windows (both of which do not support
-# processes).
-#
-# workers ENV.fetch("WEB_CONCURRENCY") { 2 }
-
-# Use the `preload_app!` method when specifying a `workers` number.
-# This directive tells Puma to first boot the application and load code
-# before forking the application. This takes advantage of Copy On Write
-# process behavior so workers use less memory.
-#
-# preload_app!
+port ENV.fetch("PORT", 3000), '127.0.0.1'
 
 # Allow puma to be restarted by `bin/rails restart` command.
 plugin :tmp_restart
+
+# Run the Solid Queue supervisor inside of Puma for single-server deployments
+plugin :solid_queue if ENV["SOLID_QUEUE_IN_PUMA"]
+
+# Specify the PID file. Defaults to tmp/pids/server.pid in development.
+# In other environments, only set the PID file if requested.
+pidfile ENV["PIDFILE"] if ENV["PIDFILE"]

config/routes.rb

@@ -1,6 +1,5 @@
 Rails.application.routes.draw do
   resources :measurements
-  resources :charts, only: [:index]
 
   resources :readouts, only: [:new] do
     collection {get 'new/:id/discard', action: :discard, as: :discard}
@@ -16,7 +15,10 @@ Rails.application.routes.draw do
 
   namespace :default do
     resources :units, only: [:index, :destroy] do
-      member { post :import, :export }
+      member {
+        post :import
+        post :export
+      }
       #collection { post :import_all }
     end
   end

db/migrate/20230309185340_create_users.rb

@@ -1,11 +1,11 @@
-class CreateUsers < ActiveRecord::Migration[7.0]
+class CreateUsers < ActiveRecord::Migration[8.1]
   def change
     create_table :users do |t|
       t.string :email, null: false, limit: 64
       t.integer :status, null: false, default: 0
 
-      t.timestamps null: false
+      t.timestamps
     end
-    add_index :users, :email, unique: true
+    add_index :users, :email
   end
 end

db/migrate/20230311220654_add_devise_to_users.rb

@@ -1,4 +1,4 @@
-class AddDeviseToUsers < ActiveRecord::Migration[7.0]
+class AddDeviseToUsers < ActiveRecord::Migration[8.1]
   def change
     change_table :users do |t|
       ## NOTE: commented fields left for reference/inclusion in future migrations
@@ -34,8 +34,8 @@ class AddDeviseToUsers < ActiveRecord::Migration[7.0]
       # t.integer :failed_attempts, default: 0, null: false 
     end
 
-    add_index :users, :reset_password_token, unique: true
-    add_index :users, :confirmation_token, unique: true
+    add_index :users, :reset_password_token
+    add_index :users, :confirmation_token
     # add_index :users, :unlock_token, unique: true
   end
 end

db/migrate/20230602185352_create_units.rb

@@ -1,14 +1,15 @@
-class CreateUnits < ActiveRecord::Migration[7.0]
+class CreateUnits < ActiveRecord::Migration[8.1]
   def change
     create_table :units do |t|
-      t.references :user, foreign_key: true
+      t.references :user, foreign_key: {on_delete: :cascade}
       t.string :symbol, null: false, limit: 15
       t.text :description
-      t.decimal :multiplier, null: false, precision: 30, scale: 15, default: 1.0
+      t.float :multiplier, null: false, limit: Float::MANT_DIG, default: 1.0
       t.references :base, foreign_key: {to_table: :units, on_delete: :cascade}
 
-      t.timestamps null: false
+      t.timestamps
     end
-    add_index :units, [:user_id, :symbol], unique: true
+    add_index :units, [:user_id, :symbol]
+    add_index :units, [:id, :user_id]
   end
 end

db/migrate/20250104194343_create_quantities.rb

@@ -1,17 +1,18 @@
-class CreateQuantities < ActiveRecord::Migration[7.2]
+class CreateQuantities < ActiveRecord::Migration[8.1]
   def change
     create_table :quantities do |t|
-      t.references :user, foreign_key: true
+      t.references :user, foreign_key: {on_delete: :cascade}
       t.string :name, null: false, limit: 31
       t.text :description
       t.references :parent, foreign_key: {to_table: :quantities, on_delete: :cascade}
 
-      t.timestamps null: false
+      t.timestamps
 
       # Caches; can be computed from other attributes
       t.integer :depth, null: false, default: 0
       t.string :pathname, null: false, limit: 511
     end
-    add_index :quantities, [:user_id, :parent_id, :name], unique: true
+    add_index :quantities, [:user_id, :parent_id, :name]
+    add_index :quantities, [:id, :user_id]
   end
 end

db/migrate/20250121230456_create_readouts.rb

@@ -1,19 +1,69 @@
-class CreateReadouts < ActiveRecord::Migration[7.2]
+class CreateReadouts < ActiveRecord::Migration[8.1]
   def change
-    create_table :readouts do |t|
-      # Reference :user through :quantity (:measurement may be NULL).
-      t.references :measurement, foreign_key: true
-      t.references :quantity, null: false, foreign_key: true
-      # :category + :value + :unit as a separate table? (NumericValue, TextValue)
-      t.integer :category, null: false, default: 0
-      t.float :value, null: false, limit: Float::MANT_DIG
-      t.references :unit, foreign_key: true
-      # Move to Measurement?
+    create_table :notes do |t|
+      t.text :text, null: false
+
+      t.timestamps
+    end
+
+    create_table :measurements do |t|
+      t.datetime :taken_at, null: false
       #t.references :collector, foreign_key: true
       #t.references :device, foreign_key: true
+      t.references :note, foreign_key: {on_delete: :nullify}
 
-      t.timestamps null: false
+      t.timestamps
     end
-    add_index :readouts, [:quantity_id, :created_at], unique: true
+    add_index :measurements, :taken_at
+
+    # Defining Readouts as a super-/subclass polymorphic relations for different
+    # subclass data types (numeric, string, file) is not possible with proper
+    # referential integrity constraints. The required constraints are:
+    # * for every subclass record to have superclass record,
+    # * for every superclass record to have only one type of subclass record,
+    # * for every superclass record to have subclass record (unenforcable).
+    #   * this can be partially remedied by making superlass an abstract class in
+    #     Rails and disallow direct creation of records, but direct data
+    #     manipulation can still break referential integrity.
+    # Defining separate {Numeric,Text,File}_Readouts tables would make the
+    # unique index constraint unenforcable.
+    create_table :readouts do |t|
+      t.references :user, null: false, foreign_key: {on_delete: :cascade}
+      t.references :measurement, foreign_key: {on_delete: :cascade}
+      t.references :quantity, null: false, foreign_key: {on_delete: :cascade}
+      t.integer :category, null: false, default: 0
+      t.float :value, null: false, limit: Float::MANT_DIG
+      t.references :unit, null: false, foreign_key: {on_delete: :cascade}
+      # TODO: consider additional columns to allow wider range of value types
+      # t.text :text
+      # t.datetime :time
+      # t.references :file
+      # Possibly mutually exclusive with :unit or check constraint for:
+      #   :unit is not null <=> :value is not null
+
+      t.timestamps
+    end
+    add_index :readouts, [:measurement_id, :quantity_id, :category]
+    add_foreign_key :readouts, :quantities, column: [:quantity_id, :user_id],
+      primary_key: [:id, :user_id]
+    add_foreign_key :readouts, :units, column: [:unit_id, :user_id],
+      primary_key: [:id, :user_id]
+
+    # TODO: remove below tables after current setup verified
+    #create_table :numeric_values do |t|
+    #  t.references :readout, null: false, foreign_key: {on_delete: :cascade}
+    #  t.float :value, null: false, limit: Float::MANT_DIG
+    #  t.references :unit, null: false, foreign_key: {on_delete: :cascade}
+    #  # + generated, not stored column :value_type
+    #  # + foreign key constraint to readouts: [:readout_id, :value_id, :value_type]
+    #  # or 2 constraints: [:readout_id, :value_id], [:value_id, :value_type]
+    #  # if readouts.value_id needed, otherwise just one constraint:
+    #  # [:readout_id, :value_type]
+    #end
+
+    #create_table :string_values do |t|
+    #  t.references :readout, null: false, foreign_key: {on_delete: :cascade}
+    #  t.string :value, null: false, limit: 32
+    #end
   end
 end