forked from fixin.me/fixin.me
Migrate all inline JS to Stimulus controllers
Add stimulus-rails gem and wire up 7 controllers: - measurements_view_controller: view toggle (compact/wide) via localStorage - measurements_controller: grouped rows MutationObserver - charts_controller: Plotly chart rendering - form_controller: keyboard shortcuts (Escape/Enter) and submit validation - details_controller: quantity picker state, focusout close, MutationObserver - readout_unit_controller: default unit button enable/disable + PATCH submission - drag_controller: drag-and-drop for quantity reparenting and unit rebasing Remove all inline onclick/onkeydown/ondrag*/onsubmit handlers from templates. Remove all window.* global exports from application.js. Remove bare <script> block from measurements/_form.html.erb. Remove turbo:load listeners for behavior now in controller connect(). application.js now only contains: Turbo Stream custom action definitions and the showPage visibility listener. Document Stimulus conventions in CLAUDE.md. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
29
app/javascript/controllers/measurements_controller.js
Normal file
29
app/javascript/controllers/measurements_controller.js
Normal file
@@ -0,0 +1,29 @@
|
||||
import { Controller } from "@hotwired/stimulus"
|
||||
|
||||
export default class extends Controller {
|
||||
static targets = ["tbody"]
|
||||
|
||||
connect() {
|
||||
this.#group()
|
||||
this._observer = new MutationObserver(() => this.#group())
|
||||
this._observer.observe(this.tbodyTarget, {
|
||||
childList: true, subtree: true,
|
||||
attributes: true, attributeFilter: ['style']
|
||||
})
|
||||
}
|
||||
|
||||
disconnect() {
|
||||
this._observer?.disconnect()
|
||||
}
|
||||
|
||||
#group() {
|
||||
let prevTakenAt = null
|
||||
Array.from(this.tbodyTarget.querySelectorAll('tr[data-taken-at]'))
|
||||
.filter(row => row.style.display !== 'none')
|
||||
.forEach(row => {
|
||||
const takenAt = row.dataset.takenAt
|
||||
row.classList.toggle('grouped', takenAt !== null && takenAt === prevTakenAt)
|
||||
prevTakenAt = takenAt
|
||||
})
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user