barbie-bot/fixin.me
0
0
Fork 0
forked from fixin.me/fixin.me
Code Pull Requests Activity

Merge feature/measurements-wide-view (fixes: data-column, fetch error handling, controller tests)

Browse Source
This commit is contained in:
barbie-bot
2026-04-04 10:24:53 +00:00
parent d1e718137d 1bc75f5d40
commit 481f509004
3 changed files with 69 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/javascript/application.js
View File

@@ -47,10 +47,8 @@ function buildWideTable() {
groupMap.get(key).rows.push(r);
});
// Read column headers from compact thead
var ths = document.querySelectorAll('.measurements-compact thead th');
var takenAtHeader = ths[3] ? ths[3].textContent : '';
var createdAtHeader = ths[4] ? ths[4].textContent : '';
var takenAtHeader = (document.querySelector('[data-column="taken-at"]') || {}).textContent || '';
var createdAtHeader = (document.querySelector('[data-column="created-at"]') || {}).textContent || '';
var table = document.createElement('table');
table.className = 'items-table';
@@ -243,7 +241,8 @@ function editMeasurementWide(url) {
panel.scrollIntoView({behavior: 'smooth', block: 'nearest'});
}
});
});
})
.catch(err => console.error('editMeasurementWide failed:', err));
}
window.editMeasurementWide = editMeasurementWide
@@ -282,7 +281,8 @@ function setDefaultUnit(button) {
}
return response.text();
})
.then(html => Turbo.renderStreamMessage(html));
.then(html => Turbo.renderStreamMessage(html))
.catch(err => console.error('setDefaultUnit failed:', err));
}
window.setDefaultUnit = setDefaultUnit

4
app/views/measurements/index.html.erb
View File

@@ -22,8 +22,8 @@
<th><%= Quantity.model_name.human %></th>
<th><%= Readout.human_attribute_name(:value) %></th>
<th><%= Unit.model_name.human %></th>
<th><%= Readout.human_attribute_name(:taken_at) %></th>
<th><%= Readout.human_attribute_name(:created_at) %></th>
<th data-column="taken-at"><%= Readout.human_attribute_name(:taken_at) %></th>
<th data-column="created-at"><%= Readout.human_attribute_name(:created_at) %></th>
<% if current_user.at_least(:active) %>
<th></th>
<% end %>