Karavel/fixin.me
0
0
Fork 0
forked from fixin.me/fixin.me
Code Pull Requests Activity

Fix tests

Browse Source
This commit is contained in:
cryptogopher 2024-12-30 00:19:16 +01:00
parent d9cc1a977b
commit b9d979ad0c
1 changed files with 12 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
test/system/units_test.rb
View File

@ -30,7 +30,7 @@ class UnitsTest < ApplicationSystemTestCase
visit units_path visit units_path
within 'tbody' do within 'tbody' do
assert_selector 'tr', count: 1 assert_selector 'tr', count: 1
assert_text t('units.index.no_items') assert_text t('units.no_items')
end end
end end
@ -74,7 +74,7 @@ class UnitsTest < ApplicationSystemTestCase
test "new and edit on validation error" do test "new and edit on validation error" do
# It's not possible to cause validation error on :edit with single unit # It's not possible to cause validation error on :edit with single unit
LINK_LABELS.delete(:edit) unless @user.units.count > 1 LINK_LABELS.delete(:edit) unless @user.units.count > 1
type, label = LINK_LABELS.assoc(LINK_LABELS.keys.sample) type, label = LINK_LABELS.to_a.sample
link = all(:link, exact_text: label).sample link = all(:link, exact_text: label).sample
link.click link.click
@ -102,16 +102,15 @@ class UnitsTest < ApplicationSystemTestCase
end end
test "new and edit allow opening multiple forms" do test "new and edit allow opening multiple forms" do
links = {} # Requires at least 1 unit to be able to open 2 forms
targets = {} links = LINK_LABELS.transform_values { |labels| all(:link, exact_text: labels).to_a }
LINK_LABELS.each_pair do |type, labels| random_link = ->{ links.transform_values(&:sample).compact.to_a.sample }
links[type] = all(:link_or_button, exact_text: labels).to_a
targets[type] = links[type].sample
end
# Define tr count change depending on link clicked # Define tr count change depending on link clicked
tr_diff = {new_unit: 1, new_subunit: 1, edit: 0} tr_diff = {new_unit: 1, new_subunit: 1, edit: 0}
type, link = targets.assoc(targets.keys.sample).tap { |t, _| targets.delete(t) } type, link = random_link[].tap { |t, l| links[t].delete(l) }
subunit_link = link.ancestor('tr')
.first(:link, LINK_LABELS[:new_subunit], between: 0..1) if type == :edit
assert_difference ->{ all('tbody tr').count }, tr_diff[type] do assert_difference ->{ all('tbody tr').count }, tr_diff[type] do
assert_difference ->{ all('tbody tr:has(input[type=text])').count }, 1 do assert_difference ->{ all('tbody tr:has(input[type=text])').count }, 1 do
link.click link.click
@ -120,16 +119,14 @@ class UnitsTest < ApplicationSystemTestCase
form = find('tbody tr:has(input:focus)') form = find('tbody tr:has(input:focus)')
if type == :edit if type == :edit
assert !link.visible? refute link.visible?
[:new_subunit, :edit].each do |t| refute subunit_link&.visible?
assert_difference(->{ links[t].length }, -1) { links[t].select!(&:visible?) } links[:new_subunit].delete(subunit_link)
end
else else
assert link[:disabled] assert link[:disabled]
end end
targets.merge([:new_subunit, :edit].map { |t| [t, links[t].sample] }.to_h) type, link = random_link[]
type, link = targets.assoc(targets.keys.sample)
assert_difference ->{ all('tbody tr').count }, tr_diff[type] do assert_difference ->{ all('tbody tr').count }, tr_diff[type] do
assert_difference ->{ all('tbody tr:has(input[type=text])').count }, 1 do assert_difference ->{ all('tbody tr:has(input[type=text])').count }, 1 do
link.click link.click