Karavel/fixin.me
0
0
Fork 0
forked from fixin.me/fixin.me
Code Pull Requests Activity

Reword comments/descriptions

Browse Source
This commit is contained in:
cryptogopher 2024-01-05 21:56:57 +01:00
parent 98c8fb9346
commit 5c70736a91
2 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/assets/stylesheets/application.css
View File

@ -95,9 +95,11 @@ button > svg {
padding-right: 0.4em; padding-right: 0.4em;
width: 1.8em; width: 1.8em;
} }
/* TODO: <a> hover/focus here and remove from table.items */
/* This is for normal links only. Button-like link styles are under .button /* TODO: move normal non-button links (<a>:hover/:focus) styling here (i.e.
* selector */ * page-wide, top-level) and remove from table.items - as the style should be
* same everywhere */
.button:focus-visible, .button:focus-visible,
button:focus-visible, button:focus-visible,
input[type=submit]:focus-visible { input[type=submit]:focus-visible {
@ -339,7 +341,7 @@ table.items td.actions {
justify-content: end; justify-content: end;
} }
/* TODO: replace :hover:focus-visible with proper stye order */ /* TODO: replace :hover:focus-visible combos with proper LOVE stye order */
table.items td.link a:hover, table.items td.link a:hover,
table.items td.link a:focus-visible, table.items td.link a:focus-visible,
table.items td.link a:hover:focus-visible { table.items td.link a:hover:focus-visible {

9
test/system/users_test.rb
View File

@ -110,8 +110,8 @@ class UsersTest < ApplicationSystemTestCase
click_on t("layouts.application.users") click_on t("layouts.application.users")
all(:link_or_button, text: t("users.index.disguise")).sample.click all(:link_or_button, text: t("users.index.disguise")).sample.click
assert_current_path edit_user_registration_path assert_current_path edit_user_registration_path
# TODO: test for profile app-menu link after root changed to different path # TODO: test for "Profile" link button after root_url changed to different
# then profile # path then profile in routes.rb
click_on t("layouts.application.revert") click_on t("layouts.application.revert")
assert_current_path users_path assert_current_path users_path
@ -134,10 +134,11 @@ class UsersTest < ApplicationSystemTestCase
assert_title "Bad request received (400)" assert_title "Bad request received (400)"
end end
test "destroy profile" do test "delete profile" do
user = users.select(&:confirmed?).sample user = users.select(&:confirmed?).sample
sign_in user: user sign_in user: user
# TODO: remove condition after root changed to different path than profile # TODO: remove condition after root_url changed to different path than
# profile in routes.rb
unless has_current_path?(edit_user_registration_path) unless has_current_path?(edit_user_registration_path)
first(:link_or_button, user.email).click first(:link_or_button, user.email).click
end end